Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[DRAFT] Add support for using PageIndicatorView #675
Conversation
| apply plugin: 'kotlin-android' | ||
| apply plugin: 'maven' | ||
| apply plugin: 'signing' | ||
| apply from: 'maven-push.gradle' |
This comment has been minimized.
This comment has been minimized.
paolorotolo
May 22, 2019
Member
You can probably drop this as well as the gradle script. Sonatype was used in the early versions of the library.
|
Yeah that makes sense,
I'm going to push a new PR that will cleanup the old publishing setup so we
have only JitPack so far.
…On Wed, May 22, 2019 at 5:16 PM Paolo Rotolo ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In appintro-indicators/build.gradle
<#675 (comment)>:
> @@ -0,0 +1,30 @@
+apply plugin: 'com.android.library'
+apply plugin: 'kotlin-android'
+apply plugin: 'maven'
+apply plugin: 'signing'
+apply from: 'maven-push.gradle'
You can probably drop this as well as the gradle script. Sonatype was used
in the early versions of the library.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#675?email_source=notifications&email_token=AAW44ZP4I3HPMB3QIXIJFMTPWVPUTA5CNFSM4HMZEPCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZMM3BY#pullrequestreview-240700807>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW44ZIDGLCQX2OKLN2FVSDPWVPUTANCNFSM4HMZEPCA>
.
--
Nicola Corti - Android @ Yelp
corti.nico@gmail.com
http://ncorti.com
"Look wide, and even when you think you are looking wide – look wider
still!"
|
|
Here you go @paolorotolo #680 |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

cortinico commentedMay 14, 2019
•
edited
This is a Draft PR for #619. I've added a new module
appintro-indicatorsthat developers can use in order to use aPageIndicatorView(and it's animation) as indicator.Here a sample:

Please note that this is not production ready yet. We probably need to:
AnimationTypeenum inside the module (we don't want developers to manually depend on thepageindicatorview, the module should work out of the box).Looking for some early feedback :) @paolorotolo @AnuthaDev
Fixes #619 Fixes #522