X Tutup
The Wayback Machine - https://web.archive.org/web/20200920034739/https://github.com/AppIntro/AppIntro/pull/675
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add support for using PageIndicatorView #675

Draft
wants to merge 2 commits into
base: master
from

Conversation

@cortinico
Copy link
Member

cortinico commented May 14, 2019

This is a Draft PR for #619. I've added a new module appintro-indicators that developers can use in order to use a PageIndicatorView (and it's animation) as indicator.

Here a sample:
May-14-2019 13-49-04

Please note that this is not production ready yet. We probably need to:

  • Fix the publishing pipeline (I saw we have a lot of legacy Sonatype publishing config).
  • Encapsulate the AnimationType enum inside the module (we don't want developers to manually depend on the pageindicatorview, the module should work out of the box).

Looking for some early feedback :) @paolorotolo @AnuthaDev

Fixes #619 Fixes #522

@cortinico cortinico requested a review from paolorotolo May 14, 2019
@cortinico cortinico self-assigned this May 14, 2019
apply plugin: 'kotlin-android'
apply plugin: 'maven'
apply plugin: 'signing'
apply from: 'maven-push.gradle'

This comment has been minimized.

@paolorotolo

paolorotolo May 22, 2019 Member

You can probably drop this as well as the gradle script. Sonatype was used in the early versions of the library.

@cortinico
Copy link
Member Author

cortinico commented May 23, 2019

@cortinico
Copy link
Member Author

cortinico commented May 23, 2019

Here you go @paolorotolo #680

@cortinico cortinico force-pushed the custom-indicator branch from fb791ab to 9b7c9ee May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.
X Tutup