X Tutup
The Wayback Machine - https://web.archive.org/web/20201110230808/https://github.com/NetLogo/NetLogo/pull/1578
Skip to content

/ NetLogo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Shape Editor Dialog Resize and Scale #1578

Closed
wants to merge 3 commits into from
Closed

Make Shape Editor Dialog Resize and Scale #1578

wants to merge 3 commits into from

Conversation

@TheFoolishMan
Copy link

@TheFoolishMan TheFoolishMan commented Feb 23, 2018 •
edited

This pull request is to address the issue (#1573)
There are 2 files which have been changed to make Shape Editor resize and scale.

ShapeView.java

  • Fixed one bug for crosshair.
  • Changed color of crosshair from dark gray to white to distinguish it.
  • Increased size from 300 to 400.

EditorDialog.java

  • Deleted drawingPanel and graphicPanel
  • Created new panel called bottomPanel which contain previewPanel and buttonPanel
  • Changed the layout of EditorDialog from BoxLayout to BorderLayout.
  • Make set resizable value of Editor Dialog to true
@TheFoolishMan
Update EditorDialog.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f64a55d 
In this commit, I have make this EditorDialog resizable and extra space is taken up by shapeView to have more shape display area.
@TheFoolishMan
Update ShapeView.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
85a101a 
Increased the size so as to have better look and fixed one small bug for crosshair.
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Feb 23, 2018 •
edited

CLA assistant check
All committers have signed the CLA.
@mrerrormessage
Copy link
Contributor

@mrerrormessage mrerrormessage commented Feb 23, 2018

These are looking like some good first steps! There are a few changes I would like to see:

  1. Some of your files have a mix of tab and space indentation. Switch your indenter two use two-spaces for tabs. You may need to reindent certain sections.
  2. The shape of the pane with the crosshairs and grid lines needs to stay a square, so that width == height. Google around and see if you can find a way to accomplish this.
  3. The shape needs to stay centered relative to the crosshairs as the pane is resized.

Please reach out if you have further questions about how to accomplish any of these changes.
@TheFoolishMan
Update EditorDialog.java
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e185fd0 
Fixed indentation
@LaCuneta
Copy link
Contributor

@LaCuneta LaCuneta commented Aug 14, 2018

If the author gets time to make the requested changes, we'll re-open this. Closing for now.
@LaCuneta LaCuneta closed this Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@TheFoolishMan @CLAassistant @mrerrormessage @LaCuneta
You can’t perform that action at this time.
X Tutup