X Tutup
The Wayback Machine - https://web.archive.org/web/20201031043758/https://github.com/lightningnetwork/lnd/issues/3598
Skip to content

/ lnd

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: How to use build tags, and what they do #3598

Open
sako0938 opened this issue Oct 14, 2019 · 5 comments
Open

Documentation: How to use build tags, and what they do #3598

sako0938 opened this issue Oct 14, 2019 · 5 comments
Labels
beginner documentation good first issue help wanted

Comments

@sako0938
Copy link

@sako0938 sako0938 commented Oct 14, 2019

Background

The binaries are built with most of the build flags already set, but when building from source you must specify which tags are desired. This is an important step to building a usable binary from source.

These flags should be listed in the docs, with what their use is for the entire system, and whether or not excluding it would break the normal function of the system.

A section on what the experimental tag does, which is required for --routing.assumechanvalid would be useful too, since it seems that tag includes everything plus some.

Maybe for another Issue? Make a build tag, which is build everything?
@sako0938
Copy link
Author

@sako0938 sako0938 commented Oct 23, 2019 •
edited

I may try and tackle this if I can, for reference, here are the tags I know about:
make && make install tags="experimental autopilotrpc signrpc walletrpc chainrpc invoicesrpc routerrpc watchtowerrpc"

for dev options:
make && make install tags="experimental autopilotrpc signrpc walletrpc chainrpc invoicesrpc routerrpc watchtowerrpc dev"
@Roasbeef Roasbeef added the beginner label Oct 30, 2019
@sako0938
Copy link
Author

@sako0938 sako0938 commented Dec 3, 2019 •
edited

Here is how to build the "go way" and also use the build tags.
GO111MODULE=on go install -v -tags experimental,autopilotrpc,signrpc,walletrpc,chainrpc,invoicesrpc,routerrpc,watchtowerrpc ./...

v0.8.1beta not being labelled properly has me paying a lot more attention to what I'm building!
@sako0938 sako0938 changed the title Document build tags in docs/INSTALL.md Documentation: How to use build tags, and what they do Dec 27, 2019
@sako0938 sako0938 mentioned this issue Dec 27, 2019
Closed
@sako0938
Copy link
Author

@sako0938 sako0938 commented Jan 10, 2020

Notation for how go uses build tags, at top of file: // +build {tag}
find . -type f -print0 | xargs -0 grep "// +build routerrpc"
Getting close to providing a PR, not sure if I will have expertise enough to show whether a node would be functional with or without a given tag, but having the tags right in the docs will help.
@sako0938
Copy link
Author

@sako0938 sako0938 commented Jan 23, 2020

How to checkout a tagged commit: git checkout tags/v0.9.0-beta
@sako0938
Copy link
Author

@sako0938 sako0938 commented Mar 20, 2020

Additional Tags: watchtowerrpc wtclientrpc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner documentation good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@Roasbeef @guggero @sako0938
You can’t perform that action at this time.
X Tutup