Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
fix: picker transition with 'el-zoom-in-top' #785
Merged
+662
−780
Conversation
fix all picker's transition and styles, including select, autocomplete, timer-picker, date-picker and so on, which transition should be 'el-zoom-in-top' and without duplication.
| gpuAcceleration, | ||
| adaptive: gpuAcceleration, |
Comment on lines
+46
to
+47
SimonaliaChen
Dec 2, 2020
Author
Collaborator
When set gpuAcceleration to false, adaptive should also be false, otherwise will get a warning.
| @select-range="setMaxSelectionRange" | ||
| /> | ||
| </div> | ||
| <div v-if="actualVisible" class="el-time-range-picker el-picker-panel"> |
SimonaliaChen
Dec 2, 2020
•
Author
Collaborator
Can you take a look? @zazzaz I am not sure whether it is a good solution. I try to remove v-if for better performance, but some errors will be thrown, such as cannot read xx from undefined. I suppose there are something wrong with the default value, but the component are toooo complicated. Could you help me out？
This was referenced Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gpuAccelerationtoPopperAutocomplete,Dropdown,Select,TimerPicker,DatePickerand so on, which transition should be 'el-zoom-in-top' and without duplication
popperAppendToBody's default value tofalseofSelectandAutocompleteto keep consistency withPopper