X Tutup
The Wayback Machine - https://web.archive.org/web/20201202154126/https://github.com/rails/rails/issues/40730
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying queues for active_storage breaks Sidekiq #40730

Open
mperham opened this issue Dec 2, 2020 · 0 comments
Open

Specifying queues for active_storage breaks Sidekiq #40730

mperham opened this issue Dec 2, 2020 · 0 comments

Comments

@mperham
Copy link
Contributor

@mperham mperham commented Dec 2, 2020

The code here specifies two new queues for active_storage jobs.

active_storage.queues.analysis = :active_storage_analysis
active_storage.queues.purge = :active_storage_purge

The issue is that each user must configure Sidekiq to listen to any new queues, meaning that every Sidekiq user who upgrades to Rails 6.1 will need to manually add these queues to their config. This is a major footgun.

https://twitter.com/stevepolitodsgn/status/1333976003505434626

My suggestion is to not specify queues but let the jobs use the system's default queue:

  active_storage.queues.analysis = nil
  active_storage.queues.purge    = nil

And allow users to override that config if they want these job types to go into other, custom queues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.
X Tutup