X Tutup
The Wayback Machine - https://web.archive.org/web/20201225065337/https://github.com/gotify/server/issues/320
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon for browser notification #320

Open
geeseven opened this issue May 25, 2020 · 1 comment
Open

icon for browser notification #320

geeseven opened this issue May 25, 2020 · 1 comment
Labels

Comments

@geeseven
Copy link

@geeseven geeseven commented May 25, 2020

Is your feature request related to a problem? Please describe.
n/a

Describe the solution you'd like
It would be nice to see the application icon within browser based notifications.

Describe alternatives you've considered
I know dunst (and maybe others) allow customization of notifications including the icon, but it would be nice if the browser just included the icon.

Additional context
n/a

@jmattheis
Copy link
Member

@jmattheis jmattheis commented May 26, 2020

The functionality should already be implemented but is a little buggy. In https://github.com/gotify/server/blob/master/ui/src/reactions.ts#L16 the image of the message must be looked up from the application store before sending the notification. This should probably fix it.

@jmattheis jmattheis added a:bug and removed a:feature labels May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup