X Tutup
The Wayback Machine - https://web.archive.org/web/20201202013609/https://github.com/flutter/engine/pull/22794
Skip to content

/ engine

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package:file to DEPS #22794

Merged
merged 1 commit into from Dec 1, 2020
Merged

Add package:file to DEPS #22794

merged 1 commit into from Dec 1, 2020

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Dec 1, 2020 •
edited

https://dart-review.googlesource.com/c/sdk/+/174382 added package:file to the DEPS in Dart.

In order to prevent these manual DEPS file fixes in the future, we should make https://github.com/flutter/buildroot/blob/master/tools/dart/create_updated_flutter_deps.py deal with new dependencies. (Tracked in flutter/flutter#71474.)

Description

Adds package:file to the DEPS file, in correspondence to https://dart-review.googlesource.com/c/sdk/+/174382.

Related Issues

Failing Dart Flutter HHH build: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-engine-linux/12295/overview

Tests

No new tests, this fixes the build.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
@dcharkes
Add file.dart to DEPS
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3cd6d87 
https://dart-review.googlesource.com/c/sdk/+/174382 added `file.dart` to the DEPS in Dart.
@googlebot googlebot added the cla: yes label Dec 1, 2020
@dcharkes dcharkes mentioned this pull request Dec 1, 2020
Open
@dcharkes dcharkes requested a review from mkustermann Dec 1, 2020
@mkustermann
mkustermann approved these changes Dec 1, 2020
View changes
@dcharkes
Copy link
Contributor Author

@dcharkes dcharkes commented Dec 1, 2020 •
edited

Make sure your PR passes all the pre-commit tests.

Wait for Cirrus to give the green light before merging a PR. Cirrus runs a bunch of pre-commit checks

The Linux Android Scenarios bot is consistently infra failing.

Running from /b/s/w/ir/cache/builder/src/flutter/testing/scenario_app/android/gradle-home/bin/bin/python
Copying file:///b/s/w/ir/k/recipe_cleanup/tmpHunuG3/diff_failures.zip [Content-Type=application/zip]...
/ [0 files][    0.0 B/  1.0 MiB]                                                
AccessDeniedException: 403 flutter-try-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to flutter_infra/flutter//diff_failures.zip.
@fluttergithubbot
Copy link
Contributor

@fluttergithubbot fluttergithubbot commented Dec 1, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Android Scenarios has failed. Please fix the issues identified (or deflake) before re-applying this label.
@dcharkes dcharkes mentioned this pull request Dec 1, 2020
Open
@dcharkes
Copy link
Contributor Author

@dcharkes dcharkes commented Dec 1, 2020

The infra failure is the last step of Linux Android Scenarios, and does not indicate a problem with this CL.

This CL restores HHH and Golem coverage, so we're landing this despite Linux Android Scenarios not being green.
@dcharkes dcharkes merged commit 747b791 into master Dec 1, 2020
19 of 20 checks passed
19 of 20 checks passed
Linux Android Scenarios Linux Android Scenarios
Details
Linux Android AOT Engine
Details
Linux Android Debug Engine
Details
Linux Fuchsia
Details
Linux Host Engine
Details
Linux Web Engine
Details
Linux Web Framework tests
Details
Mac Android AOT Engine
Details
Mac Android Debug Engine
Details
Mac Host Engine
Details
Mac Web Engine
Details
Mac iOS Engine
Details
WIP Ready for review
Details
Windows Android AOT Engine
Details
Windows Host Engine
Details
Windows Web Engine
Details
build_and_test_linux_unopt_debug Task Summary
Details
cla/google All necessary CLAs are signed
licenses_check Task Summary
Details
luci-engine
Details
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 1, 2020
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2020
@engine-flutter-autoroll
747b7912c Add file.dart to DEPS (flutter/engine#22794)
2460d0f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2020
@engine-flutter-autoroll
747b7912c Add file.dart to DEPS (flutter/engine#22794)
b01c407
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 1, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2020
@engine-flutter-autoroll
747b7912c Add file.dart to DEPS (flutter/engine#22794)
aa357d1
cbracken pushed a commit to flutter/flutter that referenced this pull request Dec 1, 2020
@engine-flutter-autoroll
Roll Engine from 20caf54 to d2ad4419bb07 (27 revisions) (#71498)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6a84b02 
* d6beaed Roll Fuchsia Linux SDK from gkfmiRsIl... to un3JixwuO... (flutter/engine#22744)

* 8832b48 Roll Skia from 888c5d3e57eb to 51b74afb84d4 (12 revisions) (flutter/engine#22746)

* e890901 Don't register CanvasKit with `define` (flutter/engine#22745)

* 3c51679 Roll Skia from 51b74afb84d4 to 452369182f6e (1 revision) (flutter/engine#22749)

* 5bf6533 Introduce a delegate class for gpu metal rendering (flutter/engine#22611)

* 5131aa4 Roll Skia from 452369182f6e to f2efb80bc316 (4 revisions) (flutter/engine#22750)

* 7b5f79f fuchsia: Ensure full-screen input interceptor (flutter/engine#22687)

* cec8a6e Manual roll of Dart SDK from ce76503f5b46 to dcd5a8f005a (flutter/engine#22766)

* 001a511 Roll Fuchsia Linux SDK from un3JixwuO... to Bnaeivv07... (flutter/engine#22757)

* b9615b1 Roll Fuchsia Mac SDK from 36uDTGJQp... to qpkZl0s5J... (flutter/engine#22753)

* c4c4763 Roll Skia from f2efb80bc316 to 8d78da910e45 (5 revisions) (flutter/engine#22754)

* dbd1abe Roll Dart SDK from dcd5a8f005a2 to 960620d2e811 (794 revisions) (flutter/engine#22768)

* 1c2a6bd Fix the unchecked conversion warning for searchPaths in PlayStoreDynamicFeatureManager (flutter/engine#22654)

* 81af789 add file package to deps in prep for glob update (flutter/engine#22770)

* a35e3fe Let FlutterFragment not pop the whole activity by default when more fragments are in the activity (flutter/engine#22692)

* adb3312 Revert "Introduce a delegate class for gpu metal rendering (#22611)" (flutter/engine#22775)

* bcc8832 Cleanup dart_runner examples & tests. (flutter/engine#22769)

* 609307d Roll Skia from 8d78da910e45 to fd41d878b13d (20 revisions) (flutter/engine#22772)

* 587c023 [web] Add new line break type (prohibited) (flutter/engine#22771)

* 6b2ed2b Roll Skia from fd41d878b13d to 70fe17e12f38 (6 revisions) (flutter/engine#22776)

* 7910a17 Roll Dart SDK from 960620d2e811 to 7a2a3968ef53 (12 revisions) (flutter/engine#22778)

* f4ada80 Roll Skia from 70fe17e12f38 to 4c6f57a23e63 (1 revision) (flutter/engine#22781)

* 3101dff [web] Optimize Matrix4.identity (flutter/engine#22622)

* a4ce848 Add FlutterPlayStoreSplitApplication for simpler opt in to Split AOT (flutter/engine#22752)

* 747b7912c Add file.dart to DEPS (flutter/engine#22794)

* 40fa345c0 Fix race condition in key event handling on Android (flutter/engine#22658)

* d2ad4419b Fix PlatformDispatcher.locale to return something meaningful when there are no locales. (flutter/engine#22608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkustermann mkustermann

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@dcharkes @fluttergithubbot @mkustermann @googlebot
You can’t perform that action at this time.
X Tutup