Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upExtension refresh? #18069
Comments
This comment has been minimized.
This comment has been minimized.
|
Can you explain in more details what do you have in mind? |
pipboy96
added
the
needs more info
label
Jun 7, 2019
pipboy96
self-assigned this
Jun 7, 2019
This comment has been minimized.
This comment has been minimized.
|
In details:
I suppose the issues above can be resolved by making "beta_2.0" (or something like that) branch and apply backward-incompatible changes there. Also, maybe it's better to make some things from scratch than rewriting that. |
This comment has been minimized.
This comment has been minimized.
|
Currently I see 90MB memory usage. |
This comment has been minimized.
This comment has been minimized.
|
Generally, I like this idea. I personally feel like the extension (not rulesets) development is slowing down to crawl. We should discuss it with actual EFF employees though. I can try developing (locally, I don't want to develop my own "competitor" to HTTPS Everywhere) my own attempt on how the extension could work if it were possible to rebuild it from scratch using today's best practices. I also want to take advantage of the fact all currently targeted browsers (including Tor Browser) support ECMAScript modules natively now. |
pipboy96
added
EFF
hold
and removed
needs more info
labels
Jun 10, 2019
This comment has been minimized.
This comment has been minimized.
|
One can mention #17143 as well |
This comment has been minimized.
This comment has been minimized.
I might have missed something but I don't see any claim on the memory usage in #12232 matched your description. I am guessing that you are referring to #16092. This measurement calculate the theoretical memory consumption by the rulesets, not the extension itself. I am open to the idea of refreshing the extension since the current code have some assumption which limit the performance. I believe this will also imply a breaking change to the ruleset format. If #17143 (comment) can be resolved, we should rewrite the whole extension in WASM, such that the improvement can be very obvious. However, I am concerned that #17268 will limit our effort to fully rewrite the extension given the uncertainty on the Google's side. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Hainish can you join the discussion? |


Saiv46 commentedJun 7, 2019
Type: other
There's still a bunch of open and old issues which is not still resolved/finished.
The release process: #981, #2697
Improving UI/UX: #1292, #1291, #17868
Performance:
#12232: Extension excessive memory usage (applies to Chrome too)
#16551: Use more performant IndexedDB instead of serialized WebStorage
Solutions: