X Tutup
The Wayback Machine - https://web.archive.org/web/20190724051045/https://github.com/EFForg/https-everywhere/issues/18069
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension refresh? #18069

Open
Saiv46 opened this issue Jun 7, 2019 · 9 comments

Comments

Projects
None yet
5 participants
@Saiv46
Copy link

commented Jun 7, 2019

Type: other
There's still a bunch of open and old issues which is not still resolved/finished.

The release process: #981, #2697
Improving UI/UX: #1292, #1291, #17868
Performance:
#12232: Extension excessive memory usage (applies to Chrome too)
#16551: Use more performant IndexedDB instead of serialized WebStorage

Solutions:

  • Refactor everything in a new branch and migrate rulesets into other repo.
  • Rewrite code and make modules for most browsers and environments (see #9958, #17268).
@pipboy96

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

Can you explain in more details what do you have in mind?

@pipboy96 pipboy96 self-assigned this Jun 7, 2019

@Saiv46

This comment has been minimized.

Copy link
Author

commented Jun 10, 2019

Sorry for the long response, my laptop charger just died.

In details:

  • #981: There was a discussion about improving the release process, does it was resolved in release #14730?
  • #2697: Why there's still no separate repository for only the rulesets? As I see, the migration process will not be so smooth for the ruleset maintainers.
  • #1291, #1292: @J0WI has already mentioned that some features are missing from Chrome/WebExtension version.
  • #17868: I don't see any progress in the discussion of UI/UX feedback.
  • #12232: While it says that this extension using 40-80 MB of memory, mine is using over 120 MB.

I suppose the issues above can be resolved by making "beta_2.0" (or something like that) branch and apply backward-incompatible changes there.

Also, maybe it's better to make some things from scratch than rewriting that.

@pipboy96

This comment has been minimized.

Copy link
Collaborator

commented Jun 10, 2019

Currently I see 90MB memory usage.

@pipboy96

This comment has been minimized.

Copy link
Collaborator

commented Jun 10, 2019

Generally, I like this idea. I personally feel like the extension (not rulesets) development is slowing down to crawl. We should discuss it with actual EFF employees though. I can try developing (locally, I don't want to develop my own "competitor" to HTTPS Everywhere) my own attempt on how the extension could work if it were possible to rebuild it from scratch using today's best practices. I also want to take advantage of the fact all currently targeted browsers (including Tor Browser) support ECMAScript modules natively now.

@pipboy96 pipboy96 added EFF hold and removed needs more info labels Jun 10, 2019

@Giltyhub

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

One can mention #17143 as well

@cschanaj

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

#12232: While it says that this extension using 40-80 MB of memory, mine is using over 120 MB.

I might have missed something but I don't see any claim on the memory usage in #12232 matched your description. I am guessing that you are referring to #16092. This measurement calculate the theoretical memory consumption by the rulesets, not the extension itself.

I am open to the idea of refreshing the extension since the current code have some assumption which limit the performance. I believe this will also imply a breaking change to the ruleset format. If #17143 (comment) can be resolved, we should rewrite the whole extension in WASM, such that the improvement can be very obvious. However, I am concerned that #17268 will limit our effort to fully rewrite the extension given the uncertainty on the Google's side.

@pipboy96

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

@cschanaj I think we should use #17268 as an opportunity to grow. Brave devs have confirmed they will not introduce anti-adblock code and will neutralize such code if it will be added by upstream. Currently there is no decision for Ungoogled Chromium.

@pipboy96

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2019

@Hainish can you join the discussion?

@Hainish

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

I've closed #981 since the release process has improved significantly since this issue was opened.

I will leave #17868 until @zoracon is back in a few months.

#12232 will be greatly improved by the addition of the WASM module: #18093

#1292 is not currently prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
X Tutup