X Tutup
The Wayback Machine - https://web.archive.org/web/20201130060725/https://github.com/deckgo/deckdeckgo/issues/605
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studio(a11y): main menu not accessible with keyboard navigation only #605

Open
donroyco opened this issue Jan 26, 2020 · 5 comments
Open

studio(a11y): main menu not accessible with keyboard navigation only #605

donroyco opened this issue Jan 26, 2020 · 5 comments

Comments

@donroyco
Copy link
Contributor

@donroyco donroyco commented Jan 26, 2020

Affected part of DeckDeckGo

  • Studio
  • Remote control
  • Documentation
  • Demo
  • Starter kit
  • Poll
  • Web Components
  • Templates

Reproduction

Steps to reproduce:

  1. Go to https://deckdeckgo.com/
  2. Navigate with tab once (main menu is focused)
  3. Press Enter
  4. Tab once again

Expected Behavior

Menu items like Home should be focusable.

Actual Behavior

The overlay for Main menu is not focusable. Tabbing through the content continues behind overlay.

Tabbing through DeckDeckGo content
The current behaviour in action. (I needed to click once to get focus inside the browser, the rest is done with tab key only)

Environment

  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): macOS
@peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Jan 26, 2020

It looks like I don't use that much often "tab" ;)

Thx for the issue @donroyco 👍

I link this one with #534, kind of the same idea

@peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Feb 21, 2020

@donroyco just had a quick test. actually, at least in the next version, the items in the menu are accessible through tabs (see gif) but the things is that the menu/popover receive the focus/tabs after the homepage has been tabbed.

any idea how could the focus/tabs could be shifted to give the priority to the opened menu?

ezgif com-video-to-gif

@donroyco
Copy link
Contributor Author

@donroyco donroyco commented Feb 21, 2020

Not sure how this would work in Ionic, I don't see some a11y documentation on ionic-menu . Is there a way to manually focus the sidebar when you know it has been triggered to open?

@peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Feb 22, 2020

@donroyco thx for the feedback! I honestly don't know neither and didn't found anything about it.

Therefore I opened a feature request in the Ionic Core as I could reproduce the exact same behavior with a blank starter kit app ionic-team/ionic-framework#20590

@donroyco
Copy link
Contributor Author

@donroyco donroyco commented Feb 22, 2020

@peterpeterparker Cool, thanks for pushing it further. I subscribed to the issue. Strange this is not available already in Ionic.

In Angular Material you can check it pretty easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup