X Tutup
The Wayback Machine - https://web.archive.org/web/20201208194219/https://github.com/flarum/core/issues/2340
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Proper Domain Event Coverage #2340

Open
askvortsov1 opened this issue Oct 2, 2020 · 0 comments
Open

Ensure Proper Domain Event Coverage #2340

askvortsov1 opened this issue Oct 2, 2020 · 0 comments

Comments

@askvortsov1
Copy link
Member

@askvortsov1 askvortsov1 commented Oct 2, 2020

Flarum provides extensibility by allowing extensions to hook into domain events. For example, various Saving, Deleting, LoggedIn, etc. Before our stable release, we should make sure that all core/bundled models (and other domain events) have are properly dispatched when they should be. For example:

There are likely other cases. After we analyze where this is needed, we might want to do this alongside #1223 (if we decide to make that change).

Anyone interested to contributing could start by assembling a list of places where changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.
X Tutup