X Tutup
The Wayback Machine - https://web.archive.org/web/20201121003650/https://github.com/github/gh-ost/pull/640
Skip to content

/ gh-ost

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing ipv6 addresses #640

Merged
merged 7 commits into from Oct 23, 2020
Merged

Parsing ipv6 addresses #640

merged 7 commits into from Oct 23, 2020

Conversation

@shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Sep 16, 2018

Fixed #604

This PR correctly parses ipv6 addresses. The following are valid:

  • 0:0:0:0:0:0:0:0
  • ::1
  • 2001:db8:1f70::999:de8:7648:6e8
  • [2001:db8:1f70::999:de8:7648:6e8]:3306

cc @Roguelazer
Shlomi Noach added 3 commits Sep 16, 2018
Shlomi Noach
Parsing ipv6 addresses
Loading status checks…
49b80df
Shlomi Noach
added testing
Loading status checks…
a7cfaa4
Shlomi Noach
support ipv6 without port
Loading status checks…
959d1af
@shlomi-noach shlomi-noach mentioned this pull request Sep 16, 2018
Closed
Shlomi Noach
Merge branch 'master' into ipv6
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
04c0be6
@Roguelazer
Copy link
Contributor

@Roguelazer Roguelazer commented Sep 18, 2018

I tested this in our staging environment and it seemed to work correctly.
@shlomi-noach
Copy link
Contributor Author

@shlomi-noach shlomi-noach commented Sep 20, 2018 •
edited

@Roguelazer thank you. It's a bit of a hack-ish solution, but it should suffice for gh-ost.
Shlomi Noach
Merge branch 'master' into ipv6
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6284a34
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_role=ghost_testing Oct 2, 2018 Inactive
@github github deleted a comment Jan 1, 2019
Shlomi Noach
Merge branch 'master' into ipv6
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
809908c
@timvaillancourt timvaillancourt added this to the v1.1.1 milestone Aug 24, 2020
@timvaillancourt
Merge branch 'master' into ipv6
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8c4cd10
@timvaillancourt timvaillancourt temporarily deployed to production/mysql_role=ghost_testing Oct 22, 2020 Inactive
@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Oct 23, 2020 •
edited

This is passing internal tests using IPV4 addresses, meaning I can confirm it doesn't break existing use cases

I tested this in our staging environment and it seemed to work correctly.

Considering the IPV6 side tested by @Roguelazer here

Thanks @shlomi-noach and @Roguelazer!
@timvaillancourt timvaillancourt merged commit e99b915 into master Oct 23, 2020
3 checks passed
3 checks passed
build
Details
build
Details
gh-ost-build-deploy-tarball Build 28348624
Details
@timvaillancourt timvaillancourt deleted the ipv6 branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement needs-testing
Projects
None yet
Milestone
v1.1.1
Linked issues

Successfully merging this pull request may close these issues.

-assume-master-host doesn't work with IPv6 literals
3 participants
@shlomi-noach @Roguelazer @timvaillancourt
You can’t perform that action at this time.
X Tutup