X Tutup
The Wayback Machine - https://web.archive.org/web/20201219231402/https://github.com/PowerShell/PowerShell/pull/3078
Skip to content

/ PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OpenCover merge and upload more reliable/usable #3078

Merged
merged 3 commits into from Feb 1, 2017
Merged

Make OpenCover merge and upload more reliable/usable #3078

merged 3 commits into from Feb 1, 2017

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Jan 31, 2017

  • Delete temporary zip file.
  • Remove CodeCov uploading through cygwin.
  • Add code to use Invoke-WebRequest to upload to Codecov
  • Wait for 1 build to start analysis.
  • Do not wait for CI.
  • Disable comments in PR.
@adityapatwardhan
Corrected the opencover option to merge the output file
f393084 
- Delete temporary zip file.
- Remove CodeCov uploading through cygwin.
- Add code to use Invoke-WebRequest to upload to CodeCov
@adityapatwardhan
Codecov settings
Loading status checks…
9b90e1a 
- Wait for 1 build to start analysis.
- Do not wait for CI.
- Disable comments in PR.
@adityapatwardhan adityapatwardhan requested a review from JamesWTruher Jan 31, 2017
@JamesWTruher
Copy link
Member

@JamesWTruher JamesWTruher commented Jan 31, 2017 •
edited by adityapatwardhan 

$_

should this be redirected to the log file? #Resolved

Refers to: test/tools/CodeCoverageAutomation/Start-CodeCoverageRun.ps1:171 in f393084. [](commit_id = f393084, deletion_comment = False)
@adityapatwardhan
Copy link
Member Author

@adityapatwardhan adityapatwardhan commented Jan 31, 2017 

$_

Fixed.

In reply to: 276459249 [](ancestors = 276459249)

Refers to: test/tools/CodeCoverageAutomation/Start-CodeCoverageRun.ps1:171 in f393084. [](commit_id = f393084, deletion_comment = False)
@adityapatwardhan
Addressed code review comments
Loading status checks…
54cfc8d
@JamesWTruher
Copy link
Member

@JamesWTruher JamesWTruher commented Jan 31, 2017

:shipit:
@adityapatwardhan
Copy link
Member Author

@adityapatwardhan adityapatwardhan commented Jan 31, 2017

@PowerShell/powershell-maintainers This is ready for merge.
@TravisEz13 TravisEz13 changed the title Open cover merge change and CodeCov settings Make OpenCover merge and upload more reliable/usable Feb 1, 2017
@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Feb 1, 2017

LGTM, except the title, I changed...
@TravisEz13 TravisEz13 merged commit 9ab8c6d into PowerShell:master Feb 1, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adityapatwardhan adityapatwardhan deleted the adityapatwardhan:OpenCoverMerge branch Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@adityapatwardhan @JamesWTruher @TravisEz13 @PowerShellTeam @msftclas @iSazonov
You can’t perform that action at this time.
X Tutup