-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Supports OkBuck build #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Supports OkBuck build #4133
Conversation
|
There seems to be a problem in OkBuck. Build with OkBuck currently fails. |
|
@malbano would you like to chime in on this? |
|
|
||
| @Override | ||
| List<String> getBootClassPathList() { | ||
| return bootClassPathList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The boot classpaths are already passed in the transform invocation as referenced input jar, so you just need to add those to your class loader.
| // constructor for OkBuck | ||
| public RealmTransformer(File configFile) { | ||
| if (!configFile.exists()) { | ||
| throw new FileNotFoundException(configFile.absolutePath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can expect this to always exist. Transform-cli does that check if a config file is specified: uber/okbuck@ebcea6f#diff-10fc19e7dd1e6127839942575e0a0ba1R59
|
@zaki50 I created https://github.com/realm/realm-java/tree/cm/okbuck-example to have an example we could point to in the repo, but ran into uber/okbuck#380 and uber/okbuck#381 |
|
@cmelchior @zaki50 I posted the configuration fix in uber/okbuck#380 (comment) The setup currently for the example is not correctly configured |
…uration in order to support OkBuck
fc1d2d8 to
3a4ea0a
Compare
|
Any luck with this? Or maybe when the RealmTransformer becomes Kotlin? :D |
|
any progress? |
|
Hi @meierjan Unfortunately not. We ran into some issues and figuring a way around those doesn't have a high priority right now. |
|
@meierjan (the current priority is preparing for RMP 2.0 scheduled for the end of Also if I gathered it right, the problem is that OkBuck can execute transform task only if it is written with non-Groovy things. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

add a constructor to RealmTransformer which takes file path of configuration in order to support OkBuck
fixes #3971
TODOs