X Tutup
The Wayback Machine - https://web.archive.org/web/20210106121014/https://github.com/nisrulz/flutter-examples/issues/70
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Request: Covid-19 Mobile App #70

Open
mehdi1514 opened this issue Oct 6, 2020 · 4 comments
Open

Example Request: Covid-19 Mobile App #70

mehdi1514 opened this issue Oct 6, 2020 · 4 comments
Assignees

Comments

@mehdi1514
Copy link

@mehdi1514 mehdi1514 commented Oct 6, 2020

Hey Nishant,

I would like to contribute to this repo. I have created a mobile app that tracks Covid-19 cases. It uses the NovelCOVID API to fetch the results. I have also included some data visualizations in the app.

@mehdi1514 mehdi1514 changed the title Covid-19 Mobile app example Example Request: Covid-19 Mobile app example Oct 6, 2020
@mehdi1514 mehdi1514 changed the title Example Request: Covid-19 Mobile app example Example Request: Covid-19 Mobile App Oct 6, 2020
@nisrulz
Copy link
Owner

@nisrulz nisrulz commented Oct 6, 2020

Great! Thank you for opening this issue.

Ok, first a few things:

  • Read the contribution guidelines in readme. Package name needs to be in a certain way so that all apps use same pattern.
  • The example app as you describe needs to be built in a way it is easily consumable. i.e split your code into files. Having one single main.dart file with a lot of nesting is not readable and also hard to review.
  • Make sure you are using the latest version of Flutter.
  • The libs you want to use can you list them down here? So I can take a look at what they are.
  • Question: Is there a requirement for using the API? If so what are those?
@mehdi1514
Copy link
Author

@mehdi1514 mehdi1514 commented Oct 7, 2020

I have changed the package name according to the guidelines. The package name in the case of this example app is github.nisrulz.

I have split the code into different files. I will document the code and also use understandable variable names as much as possible. I have also formatted the code in every file.

I am using the latest version of flutter viz. v 1.22.0

The packages used in this project are as follows:

  1. number_display - to display data in a width-limited component. For eg: it converts 2500000 to 2.5M
  2. http - to send HTTP requests to the API
  3. bezier_chart - to visualize the received data from the API
  4. folding_cell - to display a foldable cell to view details(total deaths, today cases, etc.). This foldable cell is present in the 'Affected Countries' page.

There is a requirement to use the API because without the API, it is not possible to get the data(total deaths, today deaths, total cases, active cases, etc.).

@nisrulz
Copy link
Owner

@nisrulz nisrulz commented Oct 7, 2020

Looks good to me.

I think you are good to open the PR. Make sure you branch from develop, add all your changes and then open your PR against develop.

@mehdi1514
Copy link
Author

@mehdi1514 mehdi1514 commented Oct 12, 2020

I have opened the PR. Please if you could review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup