X Tutup
The Wayback Machine - https://web.archive.org/web/20201116150214/https://github.com/sar-gupta/space/issues/3
Skip to content

/ space

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pagination for Messages #3

Open
phillip055 opened this issue Jun 18, 2018 · 3 comments
Open

Add Pagination for Messages #3

phillip055 opened this issue Jun 18, 2018 · 3 comments
Labels
enhancement good first issue help wanted

Comments

@phillip055
Copy link

@phillip055 phillip055 commented Jun 18, 2018

No description provided.

@sar-gupta
Copy link
Owner

@sar-gupta sar-gupta commented Jun 20, 2018

Hey @phillip055,
Please provide more details on this. How would pagination for messages work? With respect to date?
@phillip055
Copy link
Author

@phillip055 phillip055 commented Jun 20, 2018

So when the number of messages let's say increases till 10k messages in a room, then it doesn't make sense to load the entire bunch of messages, we can pull 50 at a time.
@sar-gupta
Copy link
Owner

@sar-gupta sar-gupta commented Jun 21, 2018 •
edited

@phillip055 Oh okay, so we should start loading from the last message, and then lazy load more as required. Nice point 👍
I'm slightly busy these days, but PRs for this are welcome! I'll try to implement this when I get the time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@phillip055 @sar-gupta
You can’t perform that action at this time.
X Tutup