X Tutup
The Wayback Machine - https://web.archive.org/web/20200518123314/https://github.com/freeCodeCamp/freeCodeCamp/pull/35298
Skip to content

/ freeCodeCamp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools): set git attributes for line endigs #35298

Merged
merged 1 commit into from Feb 22, 2019
Merged

chore(tools): set git attributes for line endigs #35298

merged 1 commit into from Feb 22, 2019

Conversation

@ValeraS
Copy link
Contributor

ValeraS commented Feb 19, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
@ValeraS ValeraS requested a review from freeCodeCamp/dev-team as a code owner Feb 19, 2019
@lipis
lipis reviewed Feb 19, 2019
View changes
.eslintrc.json Outdated
@@ -3,7 +3,11 @@
"extends": ["@freecodecamp/eslint-config", "prettier", "prettier/react"],
"plugins": ["prettier"],
"rules": {
"prettier/prettier": "error"
"prettier/prettier": "error",
"max-len": [

This comment has been minimized.

Sign in to view
Copy link
@lipis

lipis Feb 19, 2019

Contributor

let's sort the properties.
@lipis
lipis reviewed Feb 19, 2019
View changes
.gitattributes Outdated
*.ttf binary
*.eot binary
*.woff binary
*.pdf binary

This comment has been minimized.

Sign in to view
Copy link
@lipis

lipis Feb 19, 2019

Contributor

let's sort them alphabetically.
@raisedadead
raisedadead approved these changes Feb 19, 2019
View changes
Copy link
Member

raisedadead left a comment

Code LGTM. Can you address @lipis 's nit pick.
@ValeraS ValeraS force-pushed the ValeraS:fix/set-gitattributes-for-line-endigs branch 3 times, most recently from 989fcb3 to bbf4a78 Feb 19, 2019
@ValeraS
chore(tools): set git attributes for line endigs
Loading status checks…
c7579a0
@ValeraS ValeraS force-pushed the ValeraS:fix/set-gitattributes-for-line-endigs branch from bbf4a78 to c7579a0 Feb 22, 2019
@raisedadead raisedadead merged commit 0b2aac7 into freeCodeCamp:master Feb 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ValeraS ValeraS deleted the ValeraS:fix/set-gitattributes-for-line-endigs branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipis lipis

@raisedadead raisedadead

Assignees
No one assigned
Labels
scope: tools/scripts
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ValeraS @lipis @raisedadead
You can’t perform that action at this time.
X Tutup