X Tutup
The Wayback Machine - https://web.archive.org/web/20201123215040/https://github.com/github/training-kit/pull/732
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit package-lock.json #732

Merged
merged 1 commit into from Feb 4, 2020
Merged

Commit package-lock.json #732

merged 1 commit into from Feb 4, 2020

Conversation

@brianamarie
Copy link
Contributor

@brianamarie brianamarie commented Feb 3, 2020

Overview

TL;DR
This pull request adds a package-lock.json file. We believe the lack of this file is causing CI to fail on master builds.

This closes #729

Review

This is open for community reviews along with anyone from @github/services-programs 👀

@brianamarie brianamarie self-assigned this Feb 3, 2020
@a-a-ron
a-a-ron approved these changes Feb 3, 2020
Copy link
Contributor

@a-a-ron a-a-ron left a comment

This seems to have fixed the issue 👍

@brianamarie brianamarie merged commit 2dc764f into master Feb 4, 2020
1 check passed
1 check passed
build
Details
@brianamarie brianamarie deleted the package-lock branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.
X Tutup