X Tutup
The Wayback Machine - https://web.archive.org/web/20220712012120/https://github.com/angular/angular/issues/39865
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add library config to global style story #39865

Open
klauskpm opened this issue Oct 29, 2018 · 5 comments
Open

docs: add library config to global style story #39865

klauskpm opened this issue Oct 29, 2018 · 5 comments
Labels
comp: docs docsarea: library-or-schematics P3
Milestone
Backlog

Comments

@klauskpm
Copy link

@klauskpm klauskpm commented Oct 29, 2018

Today the Global Style story only features how to add includePaths on applications, but not libraries.

I could find how to do it thanks to these issues (#11249 and angular/angular-cli#11213) and the ng-packagr docs, but it would be helpful if the story featured something like the following:

Before

To add paths, use the stylePreprocessorOptions option:

"stylePreprocessorOptions": {
  "includePaths": [
    "src/style-paths"
  ]
},

After

To add paths, on an application, use the stylePreprocessorOptions option:

"stylePreprocessorOptions": {
  "includePaths": [
    "src/style-paths"
  ]
},

For libraries, use the styleIncludePaths option on ng-package.json file:

"lib": {
  "styleIncludePaths": ["src/style-paths"]
}
@Reyescult
Copy link

@Reyescult Reyescult commented Oct 29, 2018

Thank you. This is really helpful.

@Orodan
Copy link
Contributor

@Orodan Orodan commented May 3, 2019

Is there any work on it yet ? If not, I'm willing to give it a try and propose an update for the workspace configuration :)

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Nov 27, 2020

Transferring to the FW repo since the documentation to be improved in located in AIO. https://angular.io/guide/creating-libraries

@alan-agius4 alan-agius4 transferred this issue from angular/angular-cli Nov 27, 2020
@alan-agius4 alan-agius4 added comp: docs docsarea: library-or-schematics labels Nov 27, 2020
@ngbot ngbot bot added this to the needsTriage milestone Nov 27, 2020
@ngbot ngbot bot added this to the needsTriage milestone Nov 27, 2020
@jelbourn jelbourn added the P3 label Dec 2, 2020
@ngbot ngbot bot removed this from the needsTriage milestone Dec 2, 2020
@ngbot ngbot bot added this to the Backlog milestone Dec 2, 2020
@petebacondarwin petebacondarwin added the feature label May 25, 2021
@angular-robot
Copy link

@angular-robot angular-robot bot commented Jun 5, 2021

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link

@angular-robot angular-robot bot commented Jun 25, 2021

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@jessicajaniuk jessicajaniuk removed feature insufficient votes votes required labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: docs docsarea: library-or-schematics P3
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@petebacondarwin @klauskpm @jelbourn @Reyescult @Orodan @alan-agius4 @jessicajaniuk
X Tutup