X Tutup
The Wayback Machine - https://web.archive.org/web/20210924185623/https://github.com/nodejs/node/pull/36285
Skip to content

/ node Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: refactor to use more primordials #36285

Closed
wants to merge 1 commit into from
Closed

v8: refactor to use more primordials #36285

wants to merge 1 commit into from

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 26, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@aduh95
v8: refactor to use more primordials
d351815
@Trott
Copy link
Member

@Trott Trott commented Nov 28, 2020

Benchmark CI (queued): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/719/

Trott
Trott approved these changes Nov 28, 2020
View changes
lpinca
lpinca approved these changes Nov 28, 2020
View changes
@aduh95
Copy link
Contributor Author

@aduh95 aduh95 commented Nov 28, 2020

Benchmark results:

                                                          confidence improvement accuracy (*)   (**)  (***)
v8/get-stats.js n=1000000 method='getHeapSpaceStatistics'                 0.37 %       ±2.35% ±3.13% ±4.10%
v8/get-stats.js n=1000000 method='getHeapStatistics'                     -0.27 %       ±4.07% ±5.41% ±7.05%

@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 29, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34605/

@github-actions
Copy link

@github-actions github-actions bot commented Dec 1, 2020

Landed in e6e7084...dbfb10d

@github-actions github-actions bot closed this Dec 1, 2020
nodejs-github-bot added a commit that referenced this issue Dec 1, 2020
@aduh95 @nodejs-github-bot
v8: refactor to use more primordials
dbfb10d 
PR-URL: #36285
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 deleted the v8-primordials branch Dec 1, 2020
danielleadams added a commit that referenced this issue Dec 7, 2020
@aduh95 @danielleadams
v8: refactor to use more primordials
fbd5652 
PR-URL: #36285
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig added a commit to cjihrig/node that referenced this issue Dec 8, 2020
@aduh95 @cjihrig
v8: refactor to use more primordials
1c12838 
PR-URL: nodejs#36285
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this issue May 16, 2021
@aduh95 @targos
v8: refactor to use more primordials
d49ec9b 
PR-URL: #36285
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos added a commit that referenced this issue Jun 11, 2021
@aduh95 @targos
v8: refactor to use more primordials
6c1bbb5 
PR-URL: #36285
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@lpinca lpinca

Assignees
No one assigned
Labels
author ready
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@aduh95 @Trott @nodejs-github-bot @lpinca
X Tutup