X Tutup
The Wayback Machine - https://web.archive.org/web/20220323033116/https://github.com/nodejs/node/pull/36280
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update stability index linking logic #36280

Merged
merged 1 commit into from Dec 1, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 26, 2020

Fix logic that prevents stability index text from linking to itself.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc tools labels Nov 26, 2020
@Trott
Copy link
Member Author

@Trott Trott commented Nov 26, 2020

Before:
image

After:
image

aduh95
aduh95 approved these changes Nov 26, 2020
@Trott Trott added the request-ci label Nov 27, 2020
@github-actions github-actions bot removed the request-ci label Nov 27, 2020
@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 29, 2020

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 30, 2020

Fix logic that prevents stability index text from linking to itself.

PR-URL: nodejs#36280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Member Author

@Trott Trott commented Dec 1, 2020

Landed in cb023a3

@Trott Trott merged commit cb023a3 into nodejs:master Dec 1, 2020
10 checks passed
@Trott Trott deleted the stability-link branch Dec 1, 2020
danielleadams added a commit that referenced this issue Dec 7, 2020
Fix logic that prevents stability index text from linking to itself.

PR-URL: #36280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
cjihrig added a commit to cjihrig/node that referenced this issue Dec 8, 2020
Fix logic that prevents stability index text from linking to itself.

PR-URL: nodejs#36280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos added a commit that referenced this issue May 1, 2021
Fix logic that prevents stability index text from linking to itself.

PR-URL: #36280
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc tools
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup