X Tutup
The Wayback Machine - https://web.archive.org/web/20201126220240/https://github.com/flutter/flutter/pull/71096
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Migrate template to Gradle 6.7 and AGP 4.1.0" #71096

Merged
merged 1 commit into from Nov 23, 2020
Merged

Conversation

@amirh
Copy link
Member

@amirh amirh commented Nov 23, 2020

Reverts #70808

This broke flutter/plugins, see: https://cirrus-ci.com/task/6538283054268416

Cirrus CI Remove

00:03 clone
01:29 upgrade
00:04 activate
01:43 main

BUILD FAILED in 1m 25s
Running Gradle task 'assembleDebug'...                             85.9s
Gradle task assembleDebug failed with exit code 1
Failed to build debug all_plugins app.
There was a failure to compile all first party plugins together, but there were no changes detected in packages.
You are building a fat APK that includes binaries for android-arm, android-arm64, android-x64.
If you are deploying the app to the Play Store, it's recommended to use app bundles or split the APK to reduce the APK size.
    To generate an app bundle, run:
        flutter build appbundle --target-platform android-arm,android-arm64,android-x64
        Learn more: https://developer.android.com/guide/app-bundle
    To split the APKs per ABI, run:
        flutter build apk --target-platform android-arm,android-arm64,android-x64 --split-per-abi
        Learn more: https://developer.android.com/studio/build/configure-apk-splits#configure-abi-split
Running Gradle task 'assembleRelease'...                        


FAILURE: Build failed with an exception.



* Where:

Build file '/tmp/cirrus-ci-build/all_plugins/android/build.gradle' line: 24



* What went wrong:

A problem occurred evaluating root project 'android'.

> A problem occurred configuring project ':app'.

   > Failed to notify project evaluation listener.

      > org.gradle.api.file.ProjectLayout.directoryProperty(Lorg/gradle/api/provider/Provider;)Lorg/gradle/api/file/DirectoryProperty;



* Try:

Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.



* Get more help at https://help.gradle.org



BUILD FAILED in 721ms
Running Gradle task 'assembleRelease'...                         1,169ms
Gradle task assembleRelease failed with exit code 1
Failed to build release all_plugins app.
There was a failure to compile all first party plugins together, but there were no changes detected in packages.

Exit status: 2

cc @christopherfujino

This reverts commit 8e73bab.
Copy link
Contributor

@cyanglaz cyanglaz left a comment

LGTM

@amirh amirh merged commit 7df04fd into master Nov 23, 2020
71 checks passed
71 checks passed
Google testing Google testing passed!
Details
Linux analyze
Details
Linux build_aar_module_test
Details
Linux build_gallery
Details
Linux build_tests
Details
Linux customer_testing
Details
Linux docs
Details
Linux firebase_abstract_method_smoke_test
Details
Linux firebase_android_embedding_v2_smoke_test
Details
Linux firebase_release_smoke_test
Details
Linux framework_tests
Details
Linux fuchsia_precache
Details
Linux gradle_non_android_plugin_test
Details
Linux gradle_plugin_bundle_test
Details
Linux gradle_plugin_fat_apk_test
Details
Linux gradle_plugin_light_apk_test
Details
Linux module_custom_host_app_name_test
Details
Linux module_host_with_custom_build_test
Details
Linux module_test
Details
Linux plugin_test
Details
Linux tool_tests
Details
Linux web_benchmarks_html
Details
Linux web_e2e_test
Details
Linux web_integration_tests
Details
Linux web_long_running_tests
Details
Linux web_smoke_test
Details
Linux web_tests
Details
Linux web_tool_tests
Details
Mac build_aar_module_test
Details
Mac build_gallery
Details
Mac build_ios_framework_module_test
Details
Mac build_tests
Details
Mac customer_testing
Details
Mac framework_tests
Details
Mac gradle_non_android_plugin_test
Details
Mac gradle_plugin_bundle_test
Details
Mac gradle_plugin_fat_apk_test
Details
Mac gradle_plugin_light_apk_test
Details
Mac module_custom_host_app_name_test
Details
Mac module_host_with_custom_build_test
Details
Mac module_test
Details
Mac module_test_ios
Details
Mac plugin_lint_mac
Details
Mac plugin_test
Details
Mac tool_tests
Details
WIP Ready for review
Details
Windows build_aar_module_test
Details
Windows build_tests
Details
Windows customer_testing
Details
Windows framework_tests
Details
Windows gradle_non_android_plugin_test
Details
Windows gradle_plugin_bundle_test
Details
Windows gradle_plugin_light_apk_test
Details
Windows module_custom_host_app_name_test
Details
Windows module_host_with_custom_build_test
Details
Windows module_test
Details
Windows plugin_test
Details
Windows tool_tests
Details
analyze-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
docs-linux Task Summary
Details
flutter-build
Details
flutter-gold All golden file tests have passed.
Details
framework_tests-libraries-linux Task Summary
Details
framework_tests-misc-linux Task Summary
Details
framework_tests-widgets-linux Task Summary
Details
tool_tests-commands-linux Task Summary
Details
tool_tests-general-linux Task Summary
Details
web_integration_tests Task Summary
Details
web_smoke_test Task Summary
Details
@amirh amirh deleted the revert-70808-gradle_6_0 branch Nov 23, 2020
@jason-simmons
Copy link
Contributor

@jason-simmons jason-simmons commented Nov 23, 2020

The upgrade to Android Gradle plugin 4.1.0 was also causing failures in local engine builds (see #65399).

I have a fix pending (flutter/engine#22685, plus a flutter_tools change to create symlinks to the Maven metadata)

@jhass
Copy link

@jhass jhass commented Nov 23, 2020

Should reopen #58247 / #49438 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.
X Tutup