X Tutup
The Wayback Machine - https://web.archive.org/web/20201214001931/https://github.com/gogs/gogs/pull/6288
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: revert shellcheck fix #6288

Merged
merged 1 commit into from Aug 28, 2020
Merged

docker: revert shellcheck fix #6288

merged 1 commit into from Aug 28, 2020

Conversation

@unknwon
Copy link
Member

@unknwon unknwon commented Aug 28, 2020

Fixes #6287

@unknwon unknwon merged commit 1a681ad into main Aug 28, 2020
1 check passed
1 check passed
Shellcheck
Details
@unknwon unknwon deleted the fix-docker-backup branch Aug 28, 2020
@xZero707
Copy link
Contributor

@xZero707 xZero707 commented Sep 1, 2020

I just noticed errors in my container and started investigating. I thought I introduced this in my PR and kinda panicked.
I know that shellcheck does report this as error, but if you just wrap it as suggested, then bash will not treat is as argument and find will not work.

What could work, but I haven't tried:

-"${FIND_EXPRESSION}"

Anyway, I should have documented this in the code.

By the way, I can help with all Docker/shell related stuff. Just assign appropriate issues to me, no need to ask.

@unknwon
Copy link
Member Author

@unknwon unknwon commented Sep 1, 2020

@xZero707 Thanks for catching up! Yeah, I wondered -"${FIND_EXPRESSION}" might work too 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.
X Tutup