X Tutup
The Wayback Machine - https://web.archive.org/web/20260216101031/https://github.com/TheAlgorithms/Python/pull/2784
Skip to content

Added Segment Tree in python#2784

Closed
KoulickS wants to merge 3 commits intoTheAlgorithms:masterfrom
KoulickS:master
Closed

Added Segment Tree in python#2784
KoulickS wants to merge 3 commits intoTheAlgorithms:masterfrom
KoulickS:master

Conversation

@KoulickS
Copy link

@KoulickS KoulickS commented Oct 4, 2020 •
edited
Loading

Describe your change:

Added Segment Tree

  • Add an algorithm? Yes
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [-] I have read CONTRIBUTING.md.
  • [-] This pull request is all my own work -- I have not plagiarized.
  • [-] I know that pull requests will not be merged if they fail the automated tests.
  • [-] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [-] All new Python files are placed inside an existing directory.
  • [-] All filenames are in all lowercase characters with no spaces or dashes.
  • [-] All functions and variable names follow Python naming conventions.
  • [-] All function parameters and return values are annotated with Python type hints.
  • [-] All functions have doctests that pass the automated testing.
  • [-] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [-] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

TravisBuddy commented Oct 4, 2020

Travis tests have failed

Hey @KoulickS,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 92a0e500-068f-11eb-a99f-97db2ffc4a93

@poyea
Copy link
Member

poyea commented Oct 8, 2020

Thanks. Did you check https://github.com/TheAlgorithms/Python/blob/master/data_structures/binary_tree/segment_tree_other.py and https://github.com/TheAlgorithms/Python/blob/master/data_structures/binary_tree/lazy_segment_tree.py ? Are there any differences between yours and the two? Feel free to improve those versions.

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@KoulickS KoulickS closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale Used to mark an issue or pull request stale.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KoulickS @TravisBuddy @poyea
X Tutup