X Tutup
The Wayback Machine - https://web.archive.org/web/20260215003811/https://github.com/TheAlgorithms/Python/pull/2558
Skip to content

created a file for AVL trees#2558

Closed
rohitmadrileno15 wants to merge 1 commit intoTheAlgorithms:masterfrom
rohitmadrileno15:rohitmadrileno15
Closed

created a file for AVL trees#2558
rohitmadrileno15 wants to merge 1 commit intoTheAlgorithms:masterfrom
rohitmadrileno15:rohitmadrileno15

Conversation

@rohitmadrileno15
Copy link

@rohitmadrileno15 rohitmadrileno15 commented Oct 1, 2020 •
edited
Loading

Describe your change:

  • Added an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@spamegg1
Copy link
Contributor

spamegg1 commented Oct 1, 2020 •
edited
Loading

pre-commit says

-# print(getHeight(root))
\ No newline at end of file
...
Error: Process completed with exit code 1.

Travis CI says

E File "/home/travis/build/TheAlgorithms/Python/traversals/avl_trees.py", line 100
E print(root.val)
E ^
E TabError: inconsistent use of tabs and spaces in indentation

You can fix these types of errors by running black on your code before submitting. pip install black and then black avl_trees.py. Read CONTRIBUTING.md for more help with black.

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@poyea
Copy link
Member

poyea commented Nov 26, 2020

Thanks @rohitmadrileno15. Any luck on improving this? Or you may take a look at our existing implementation and make some fixes.

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 26, 2020
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 26, 2020
@rohitmadrileno15
Copy link
Author

rohitmadrileno15 commented Nov 26, 2020 via email

@dhruvmanila dhruvmanila reopened this Nov 28, 2020
@ghost ghost added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Nov 28, 2020
@stale
Copy link

stale bot commented Dec 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Dec 28, 2020
@stale
Copy link

stale bot commented Jan 4, 2021

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale Used to mark an issue or pull request stale. tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rohitmadrileno15 @spamegg1 @poyea @dhruvmanila
X Tutup