Web programming contribution by niranjan195 · Pull Request #2436 · TheAlgorithms/Python

niranjan195 · 2020-09-16T11:43:40Z

Describe your change:

Added Currency Converter Program to web_programming directory.

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

TravisBuddy · 2020-09-16T11:47:25Z

Hey @niranjanhegde144,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 62e11780-f812-11ea-8f9f-a900ee46d44b

niranjan195 · 2020-09-25T07:32:49Z

Clauss Can you take a look at this

cclauss · 2020-09-25T07:53:35Z

web_programming/currency_converter.py

+import requests
+
+API_KEY = ""  # <-- Put your API Key here


We need to change this. For security reasons, we do not want to encourage users to put security credentials into Python files. Instead, we will get the key at runtime from an environment variable.

The user will run the program with this command:
AMDOREN_API_KEY="This is my key" python3 web_programming/currency_converter.py

Suggested change

import requests

API_KEY = "" # <-- Put your API Key here

import os

import requests

assert API_KEY := os.environ["AMDOREN_API_KEY"], (

"Please put your API key in an environment variable."

)

cclauss · 2020-09-25T08:11:21Z

web_programming/currency_converter.py

+def convert_currency(
+    baseCurrency: str = "USD",
+    targetCurrency: str = "INR",
+    amount: float = 1.0,
+    apiKey: str = API_KEY,
+) -> str:
+    """https://www.amdoren.com/currency-api/"""
+    res = requests.get(
+        f"{URL_BASE}?api_key={API_KEY}&from={baseCurrency}&to={targetCurrency}&\
+            amount={amount}"
+    ).json()
+    if res["error"] == 0:
+        return str(res["amount"])
+    return res["error_message"]


Suggested change

def convert_currency(

baseCurrency: str = "USD",

targetCurrency: str = "INR",

amount: float = 1.0,

apiKey: str = API_KEY,

) -> str:

"""https://www.amdoren.com/currency-api/"""

res = requests.get(

f"{URL_BASE}?api_key={API_KEY}&from={baseCurrency}&to={targetCurrency}&\

amount={amount}"

).json()

if res["error"] == 0:

return str(res["amount"])

return res["error_message"]

def convert_currency(

from_: str = "USD",

to: str = "INR",

amount: float = 1.0,

api_key: str = API_KEY

) -> str:

"""https://www.amdoren.com/currency-api/"""

params = locals()

params["from"] = params.pop("from_") # 'from' is a Python keyword

res = requests.get(URL_BASE, params=params).json()

return str(res["amount"] if res["error"] == 0 else res["error_message"])

There are nice advantages in requests and locals() if our function parameter names exactly match the API.

cclauss · 2020-09-25T08:13:14Z

web_programming/currency_converter.py

+    base_currency = input("Enter base currency: ").strip()
+    target_currency = input("Enter target currency: ").strip()
+    amount = float(input("Enter the amount: ").strip())
+    print(
+        convert_currency(
+            baseCurrency=base_currency, targetCurrency=target_currency, amount=amount
+        )
+    )


Suggested change

base_currency = input("Enter base currency: ").strip()

target_currency = input("Enter target currency: ").strip()

amount = float(input("Enter the amount: ").strip())

print(

convert_currency(

baseCurrency=base_currency, targetCurrency=target_currency, amount=amount

)

)

print(

convert_currency(

input("Enter from currency: ").strip(),

input("Enter to currency: ").strip(),

float(input("Enter the amount: ").strip())

)

)

…into web_programming_contribution

TravisBuddy · 2020-09-26T10:02:29Z

Hey @niranjanhegde144,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 61ca28d0-ffdf-11ea-9882-0125ab0f75bf

TravisBuddy · 2020-09-26T10:08:38Z

Travis tests have failed

Hey @niranjanhegde144,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 268e7950-ffe0-11ea-9882-0125ab0f75bf

cclauss · 2020-09-26T10:58:06Z

https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

stale · 2020-11-21T07:38:17Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

* Currency Converter * currency converter * Currency Converter * currency converter * implemented changes * Implemented changes requested * TESTING = os.getenv("CONTINUOUS_INTEGRATION", False) * Update currency_converter.py * Update currency_converter.py Co-authored-by: Christian Clauss <cclauss@me.com>

niranjan195 added 3 commits September 16, 2020 16:49

Currency Converter

304625d

currency converter

963a912

Currency Converter

87533ed

currency converter

47cb760

niranjan195 closed this Sep 16, 2020

niranjan195 reopened this Sep 16, 2020

cclauss requested changes Sep 25, 2020

View reviewed changes

niranjan195 added 3 commits September 26, 2020 09:29

implemented changes

10c7f4f

Merge branch 'master' of https://github.com/niranjanhegde144/Python-1 …

bef8610

…into web_programming_contribution

Implemented changes requested

6070213

niranjan195 force-pushed the web_programming_contribution branch from 6f96b53 to bef8610 Compare September 26, 2020 09:58

TESTING = os.getenv("CONTINUOUS_INTEGRATION", False)

ea45c82

stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020

Update currency_converter.py

2776706

ghost added the require tests Tests [doctest/unittest/pytest] are required label Nov 21, 2020

cclauss approved these changes Nov 21, 2020

View reviewed changes

ghost added the tests are failing Do not merge until tests pass label Nov 21, 2020

Update currency_converter.py

e77e96d

ghost removed the tests are failing Do not merge until tests pass label Nov 21, 2020

cclauss merged commit f036b9f into TheAlgorithms:master Nov 21, 2020

Jan	FEB	Mar
	14
2025	2026	2027

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Web programming contribution#2436

Web programming contribution#2436
cclauss merged 10 commits intoTheAlgorithms:masterfrom
niranjan195:web_programming_contribution

niranjan195 commented Sep 16, 2020 •

edited

Loading

Uh oh!

TravisBuddy commented Sep 16, 2020

Uh oh!

niranjan195 commented Sep 25, 2020

Uh oh!

cclauss Sep 25, 2020

Uh oh!

cclauss Sep 25, 2020 •

edited

Loading

Uh oh!

cclauss Sep 25, 2020

Uh oh!

TravisBuddy commented Sep 26, 2020

Uh oh!

TravisBuddy commented Sep 26, 2020

Uh oh!

cclauss commented Sep 26, 2020

Uh oh!

stale bot commented Nov 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

niranjan195 commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

TravisBuddy commented Sep 16, 2020

TravisBuddy Request Identifier: 62e11780-f812-11ea-8f9f-a900ee46d44b

Uh oh!

niranjan195 commented Sep 25, 2020

Uh oh!

cclauss Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

cclauss Sep 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

TravisBuddy commented Sep 26, 2020

TravisBuddy Request Identifier: 61ca28d0-ffdf-11ea-9882-0125ab0f75bf

Uh oh!

TravisBuddy commented Sep 26, 2020

Travis tests have failed

TravisBuddy Request Identifier: 268e7950-ffe0-11ea-9882-0125ab0f75bf

Uh oh!

cclauss commented Sep 26, 2020

Uh oh!

stale bot commented Nov 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

niranjan195 commented Sep 16, 2020 •

edited

Loading

cclauss Sep 25, 2020 •

edited

Loading