X Tutup
The Wayback Machine - https://web.archive.org/web/20220323033055/https://github.com/nodejs/node/pull/36206
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark : changed fstat to fstatSync #36206

Closed
wants to merge 1 commit into from
Closed

benchmark : changed fstat to fstatSync #36206

wants to merge 1 commit into from

Conversation

Narasimha1997
Copy link
Contributor

@Narasimha1997 Narasimha1997 commented Nov 21, 2020 •
edited by aduh95

Changed fstat to fstatSync as mentioned in the issue #36199

Fixes: #36199

@nodejs-github-bot nodejs-github-bot added benchmark fs labels Nov 21, 2020
aduh95
aduh95 approved these changes Nov 21, 2020
View changes
@aduh95 aduh95 requested a review from mscdex Nov 21, 2020
lpinca
lpinca approved these changes Nov 21, 2020
View changes
@gireeshpunathil gireeshpunathil mentioned this pull request Nov 23, 2020
Closed
2 tasks
Trott
Trott approved these changes Nov 24, 2020
View changes
@Trott Trott added the request-ci label Nov 24, 2020
@github-actions github-actions bot removed the request-ci label Nov 24, 2020
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@Narasimha1997 Narasimha1997 requested a review from aduh95 Nov 25, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 25, 2020 •
edited by aduh95

CI: https://ci.nodejs.org/job/node-test-pull-request/34555/ ✅

@aduh95 aduh95 added the author ready label Nov 25, 2020
@gireeshpunathil gireeshpunathil added the commit-queue label Nov 26, 2020
@github-actions github-actions bot removed the commit-queue label Nov 26, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Nov 26, 2020

Landed in 2b21a31...49abda7

@github-actions github-actions bot closed this Nov 26, 2020
nodejs-github-bot added a commit that referenced this issue Nov 26, 2020
@Narasimha1997 @nodejs-github-bot
benchmark : changed fstat to fstatSync
49abda7 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Nov 26, 2020

thanks @Narasimha1997 for the contribution! 🎉

@Narasimha1997
Copy link
Contributor Author

@Narasimha1997 Narasimha1997 commented Nov 26, 2020

@gireeshpunathil ,
Thank you so much. Looking forword to contribute and learn more in the coming days.

danielleadams added a commit that referenced this issue Dec 7, 2020
@Narasimha1997 @danielleadams
benchmark : changed fstat to fstatSync
2344e3e 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
targos added a commit that referenced this issue May 1, 2021
@Narasimha1997 @targos
benchmark : changed fstat to fstatSync
2bbf253 
PR-URL: #36206
Fixes: #36199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@Trott Trott

@lpinca lpinca

@gireeshpunathil gireeshpunathil

@mscdex mscdex

@aduh95 aduh95

Assignees
No one assigned
Labels
author ready benchmark fs
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

benchmark: dead code
7 participants
@Narasimha1997 @nodejs-github-bot @gireeshpunathil @jasnell @Trott @lpinca @aduh95
X Tutup