Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up#1087 Fix stack overflow unless VS2017 is not installed #1089
Conversation
limenote135
force-pushed the
limenote135:fix_stackoverflow
branch
2 times, most recently
from
3a8e6dd
to
0f172c0
limenote135
force-pushed the
limenote135:fix_stackoverflow
branch
from
0f172c0
to
f60ad1d
|
Thank you for this fix. Unfortunately, it crashes for me with an invalid path. Assuming all tests pass for you and so does our CI, I am going to take a look myself as soon as possible. Meanwhile, please use your custom copy. |
|
Thank you for the checking. I'll use my change for now. |
ddobrev
force-pushed the
mono:master
branch
12 times, most recently
from
0464938
to
637018f
ddobrev
force-pushed the
mono:master
branch
4 times, most recently
from
91e219c
to
32da859
|
Hey @limenote135. I think we merged some VS fixes a little while ago. Could you check if there is still an issue with latest revisions? |
tritao
force-pushed the
mono:master
branch
2 times, most recently
from
a0169c2
to
3ea7e97
ddobrev
force-pushed the
mono:master
branch
2 times, most recently
from
a1559de
to
304d673
ddobrev
force-pushed the
mono:master
branch
6 times, most recently
from
0e0b4cc
to
d90d328
ddobrev
force-pushed the
mono:master
branch
2 times, most recently
from
c8e9f62
to
be54a8b
ddobrev
force-pushed the
mono:master
branch
6 times, most recently
from
1610aa5
to
64b1efd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
limenote135 commentedMay 17, 2018
Fixes #1087