X Tutup
The Wayback Machine - https://web.archive.org/web/20201125013840/https://github.com/marktext/marktext/pull/1993
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix context menu on macos #1993

Merged
merged 5 commits into from Mar 25, 2020
Merged

fix context menu on macos #1993

merged 5 commits into from Mar 25, 2020

Conversation

@Jocs
Copy link
Member

@Jocs Jocs commented Mar 22, 2020

Q A
Bug fix? yes
New feature? no
Breaking changes? no
Deprecations? no
New tests added? not needed
Fixed tickets #1915
License MIT

Description

@fxha I found that electron change the argument of menu.popup to an array, I didn't test whether it will affect other systems(Windows or Linux), so can you help test it?

[Description of the bug or feature]


This change is Reviewable

Jocs added 5 commits Mar 22, 2020
@Jocs
Copy link
Member Author

@Jocs Jocs commented Mar 22, 2020

@fxha I can not find the reason why travis-ci failed, do you know the reason?

@fxha
fxha approved these changes Mar 24, 2020
Copy link
Contributor

@fxha fxha left a comment

I found that electron change the argument of menu.popup to an array, I didn't test whether it will affect other systems(Windows or Linux), so can you help test it?

Everything seems to work fine after a quick rebuild.

@fxha I can not find the reason why travis-ci failed, do you know the reason?

I guess this is/was a Travis CI (server) error: https://travis-ci.community/t/macos-build-an-error-occurred-while-generating-the-build-script/7684 - not on our side. Maybe we should consider to switch continuous integration for Linux and macOS to Microsoft (Azure Pipelines) or CircleCI because the macOS worker has constantly problems and I also lost access to Travis Mark Text group because Travis don't recognize me as a user with write access of the Mark Text organisation. I think, you should try to rebuild the PR or alternatively delete all cache files, rebuild latest develop commit, wait to complete and rebuild this PR.

@Jocs Jocs merged commit fe641a6 into develop Mar 25, 2020
3 checks passed
3 checks passed
License Compliance All checks passed.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jocs Jocs deleted the fix-context-meun-on-macos branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup