X Tutup
The Wayback Machine - https://web.archive.org/web/20220519115150/https://github.com/preconstruct/preconstruct/pull/343
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect package.json#browser when bundling dependencies for the UMD build #343

Merged

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 7, 2020

Relates to #339

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Nov 7, 2020

🦋 Changeset detected

Latest commit: e49cabb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preconstruct/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist Andarist force-pushed the umd/resolve-browser-aliases branch from 3dc0645 to e49cabb Compare Nov 7, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 7, 2020

Codecov Report

Merging #343 (e49cabb) into master (a198073) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   84.96%   84.89%   -0.08%     
==========================================
  Files          33       33              
  Lines        1377     1377              
  Branches      338      338              
==========================================
- Hits         1170     1169       -1     
- Misses        202      203       +1     
  Partials        5        5              
Impacted Files Coverage Δ
packages/cli/src/build/rollup.ts 86.36% <ø> (ø)
packages/cli/src/build/config.ts 81.48% <0.00%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a198073...e49cabb. Read the comment docs.

@mitchellhamilton mitchellhamilton merged commit 3c031da into preconstruct:master Nov 8, 2020
9 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
X Tutup