X Tutup
The Wayback Machine - https://web.archive.org/web/20201125011918/https://github.com/TheAlgorithms/Python/pull/3934
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New algorithm added #3934

Open
wants to merge 16 commits into
base: master
from
Open

New algorithm added #3934

wants to merge 16 commits into from
+46 −0

Conversation

@erdum
Copy link

@erdum erdum commented Nov 22, 2020

Describe your change:

Finnaly i did it now i hope all checks should be clear

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@erdum
New algorithm added
Loading status checks…
3986d64
@erdum

This comment has been minimized.

Sign in to view
Copy link
Owner Author

@erdum erdum commented on 3986d64 Nov 22, 2020

I have work a lot on this file and again make new Pr this time i follow all the guidelines styling conventions now lets see what will happen??
erdum added 7 commits Nov 22, 2020
@erdum
Errors resolvedc
Loading status checks…
fa26af6
@erdum
New Algorithm
Loading status checks…
dd10b84
@erdum
New algorithm added
Loading status checks…
01cf2d3
@erdum
Added new algorithm
Loading status checks…
79cc57c
@erdum
work
Loading status checks…
75c0eea
@erdum
New algorithm added
Loading status checks…
71fa550
@erdum
Hope this is final
Loading status checks…
873b6eb
@erdum
Copy link
Author

@erdum erdum commented Nov 22, 2020

Thank god i made my first ever github contribution, i was very difficult for a beginner, but i did it, jus please review it and merged it i will more happy if you will merged it thanks.
@xcodz-dot
xcodz-dot reviewed Nov 23, 2020
View changes
electronics/ohms_law.py Show resolved Hide resolved
@erdum @xcodz-dot
Update electronics/ohms_law.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
136887e 
Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com>
@erdum erdum mentioned this pull request Nov 23, 2020
Closed
@cclauss
cclauss requested changes Nov 24, 2020
View changes
electronics/ohms_law.py Outdated Show resolved Hide resolved
electronics/ohms_law.py Outdated Show resolved Hide resolved
electronics/ohms_law.py Show resolved Hide resolved
electronics/ohms_law.py Outdated
result = float(current * resistance)
return result
Comment on lines 19 to 20

This comment has been minimized.

Sign in to view
@cclauss

cclauss Nov 24, 2020
Member

I think your function should return a dict or even better a namedtuple which provides both the name of the value and the value itself.

Creating result on one line and getting rid of it on the next is not helpful.

Suggested change
result = float(current * resistance)
return result
return {"voltage": float(current * resistance)}
@cclauss
cclauss reviewed Nov 24, 2020
View changes
electronics/ohms_law.py Outdated
>>> ohms_law(voltage=10, resistance=5,current=0 )
2.0
>>> ohms_law(current=1, resistance=10, voltage=0)
10.0

This comment has been minimized.

Sign in to view
@cclauss

cclauss Nov 24, 2020
Member

Test for numbers with fractional parts (1.5) and negative numbers, etc.

This comment has been minimized.

Sign in to view
@erdum

erdum Nov 24, 2020
Author

No problem i will be right back
erdum and others added 3 commits Nov 24, 2020
@erdum
update decimal value & negative value test
Loading status checks…
a120c71
@erdum
update as cclauss suggest
Loading status checks…
b3d0f38
@erdum @cclauss
Update electronics/ohms_law.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d36b7a0 
Co-authored-by: Christian Clauss <cclauss@me.com>
@erdum
Copy link
Author

@erdum erdum commented Nov 24, 2020

But cclauss thank you so much showing interest in my code before you nobody even tell me the problems with my code thank you again and i will be add these changes as you tell me .
@erdum
Copy link
Author

@erdum erdum commented Nov 24, 2020

So i got it what you suggest me is

  1. return dictionary with value name instead value
  2. doctest import is made inside main
  3. Comments should be helpful for reader
  4. And for wrong value input value error should be raised instead returning 0
@erdum erdum requested a review from cclauss Nov 24, 2020
erdum added 3 commits Nov 24, 2020
@erdum
updated as suggested by cclauss
0fd3f58
@erdum
update as suggested by cclauss
Loading status checks…
da97450
@erdum
update as suggested by cclauss
Loading status checks…
0af817c
@erdum
Copy link
Author

@erdum erdum commented Nov 24, 2020

cclauss i did it finally
@erdum
Update as suggested by cclauss
Loading status checks…
f8bf2b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcodz-dot xcodz-dot

@cclauss cclauss

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Status: awaiting changes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@erdum @cclauss @xcodz-dot
You can’t perform that action at this time.
X Tutup