Mimetype rulesets change for Opera #19367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason this is being done: Opera will not update the extension if 'default.rulesets' remain Of course this file name change effects ruleset signing AND hosted rulesets. So this will be done in stages. This first commit will introduce the new file first
zoracon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Changing the
default.rulesetsfile over by naming the extension.This is because Opera will not accept this file unfortunately as is. I tried to find ways to make this work without having to create a new file. But coming up short on good ideas. If anyone would like to suggest a work around, I'd appreciate it.
My last idea is packaging the CRX file for Opera differently in the build process to include
.json. But leaving this draft up for the time being until I make the final decision to change. Which would entail migrating over in small phases and letting stakeholders who use the hosted set of rulesets know that this file name is changing.