Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fog catcher: Propagation task executions and no-SQL persistence #213
Conversation
|
Besides the comments I have added, there are two additional things to cover:
|
...pache/syncope/client/console/panels/GroupDirectoryPanel_fr_CA.properties
Show resolved
Hide resolved
core/logic/src/main/java/org/apache/syncope/core/logic/SyncopeLogic.java
Show resolved
Hide resolved
| append(" t WHERE "); | ||
| if (type == TaskType.SCHEDULED) { | ||
| if (SchedTask.class.isAssignableFrom(reference)) { |
ilgrosso
Sep 9, 2020
Member
This is not correct, as type == TaskType.SCHEDULE used to match only SchedTask while now this is also matching PushTask, PullTask and so on.
...rc/main/java/org/apache/syncope/core/persistence/jpa/dao/JPATaskDAO.java
Show resolved
Hide resolved
...rc/main/java/org/apache/syncope/core/persistence/jpa/dao/JPATaskDAO.java
Show resolved
Hide resolved
...g/apache/syncope/core/persistence/jpa/entity/task/AbstractSchedTask.java
Show resolved
Hide resolved
| @@ -42,6 +43,7 @@ | |||
| * The referred task. | |||
| */ | |||
| @ManyToOne(optional = false) | |||
| @JoinColumn(name = "task_id", nullable = false) | |||
andrea-patricelli
Oct 6, 2020
Author
Contributor
Yes, this is needed. Without this the tests org.apache.syncope.core.persistence.jpa.outer.TaskTest are going to fail with errors like Column "TASKEXEC.TASK_ID" not found;.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is the fog-catcher implementation for "Propagation task executions and no-SQL persistence", that includes: