Prevent asserting with significant expressions #126
Conversation
| } | ||
|
|
||
| // This function runs on the main thread after `ExecuteWork` exits. | ||
| static void WorkComplete(napi_env env, napi_status status, void* data) { | ||
| AddonData* addon_data = (AddonData*)data; | ||
| napi_status s; |
mhdawson
Feb 14, 2020
Member
A nit but I'd prefer a more complete name, for example status versus the one letter name
|
LGTM with suggestion |
so it runs in non-debug builds PR-URL: #79 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Also renamed category node-api to napi
|
@mhdawson updated :) |
|
@legendecas most often we squash all of the comments which is what I did in this case. I see there is a PR from another commit. We probably should have landed that separately by fixing up the conflicts in the PR if possible. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Also renamed category
node-apitonapiAdditional to #79.