X Tutup
The Wayback Machine - https://web.archive.org/web/20220228053202/https://github.com/webpack/webpack/pull/11927
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape brackets in the resource name so they don't get removed during… #11927

Merged
merged 6 commits into from Nov 11, 2020

Conversation

@jasonwilliams
Copy link
Contributor

@jasonwilliams jasonwilliams commented Nov 4, 2020

… template

This is my attempt to fix #11456

This escapes the [ and ] characters, then converts them back at the end of the templating.
Unittest added

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Nov 4, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Nov 4, 2020

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

sokra
sokra approved these changes Nov 11, 2020
@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Nov 11, 2020

It looks like this Pull Request doesn't include enough test cases (based on Code Coverage analysis of the PR diff).

A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future).

@jasonwilliams Please check if this is appliable to your PR and if you can add more test cases.

Read the test readme for details how to write test cases.

@jasonwilliams
Copy link
Contributor Author

@jasonwilliams jasonwilliams commented Nov 11, 2020

@sokra do I need to do anything about that message?

@sokra sokra merged commit f58831e into webpack:master Nov 11, 2020
20 of 22 checks passed
@sokra
Copy link
Member

@sokra sokra commented Nov 11, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
X Tutup