X Tutup
The Wayback Machine - https://web.archive.org/web/20200627234946/https://github.com/angular/angular/pull/34651
Skip to content

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump year #34651

Closed
wants to merge 3 commits into from
Closed

build: bump year #34651

wants to merge 3 commits into from
+34 −34

Conversation

@CaerusKaru
Copy link
Member

CaerusKaru commented Jan 6, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
@CaerusKaru
build: bump year
Loading status checks…
3764657
@CaerusKaru CaerusKaru requested review from kara and angular/dev-infra-framework as code owners Jan 6, 2020
@googlebot googlebot added the cla: yes label Jan 6, 2020
@StephenFluin
StephenFluin requested changes Jan 6, 2020
View changes
aio/content/guide/static-query-migration.md Outdated Show resolved Hide resolved
@CaerusKaru
fixup! build: bump year
Loading status checks…
ac1a85c
@StephenFluin
StephenFluin approved these changes Jan 6, 2020
View changes
Copy link
Member

StephenFluin left a comment

LGTM. I'll defer to others regarding overall legal requirements for changing year.
@filipesilva
filipesilva approved these changes Jan 7, 2020
View changes
@petebacondarwin
petebacondarwin approved these changes Jan 7, 2020
View changes
@gkalpak
gkalpak approved these changes Jan 7, 2020
View changes
Copy link
Member

gkalpak left a comment

Could you also update aio/src/404-body.html, which seems to be stuck in 2018 😁
@devversion
devversion approved these changes Jan 7, 2020
View changes
Copy link
Member

devversion left a comment

LGTM. FYI: It looks like there is a second PR for bumping the year: #34604
@gkalpak gkalpak mentioned this pull request Jan 7, 2020
Closed
@CaerusKaru
fixup! build: bump year
Loading status checks…
10b98e6
@CaerusKaru
Copy link
Member Author

CaerusKaru commented Jan 7, 2020

@gkalpak All set 👍
@ngbot ngbot bot modified the milestone: needsTriage Jan 7, 2020
@IgorMinar
IgorMinar approved these changes Jan 12, 2020
View changes
Copy link
Member

IgorMinar left a comment

thanks!
@IgorMinar
Copy link
Member

IgorMinar commented Jan 12, 2020

merge-assistance: global approval
@atscott atscott closed this in 55037d1 Jan 13, 2020
atscott added a commit that referenced this pull request Jan 13, 2020
@CaerusKaru @atscott
build: bump year (#34651)
Loading status checks…
0067526 
PR Close #34651
@CaerusKaru CaerusKaru deleted the CaerusKaru:adam/year branch Jan 13, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 13, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin

@StephenFluin StephenFluin

@IgorMinar IgorMinar

@filipesilva filipesilva

@devversion devversion

@gkalpak gkalpak

@angular/fw-zones fw-zones

@kara kara

Assignees
No one assigned
Labels
PR action: merge PR action: merge-assistance PR target: master & patch cla: yes
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@CaerusKaru @IgorMinar @petebacondarwin @StephenFluin @filipesilva @devversion @gkalpak @googlebot
You can’t perform that action at this time.
X Tutup