Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for NaN value #49
Open
Conversation
NaN cannot be checked as equality. This commit add a test based on isNaN
Typescript definitions
|
Just some thoughts. |
| @@ -173,5 +174,15 @@ describe('.diff', () => { | |||
| expect(diff(lhs, rhs)).toEqual({ b: 2 }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('nested NaN', () => { | |||
| test('returns empty object when there is nested NaN value', () => { | |||
anko
Jan 7, 2020
This test description confused me.
More concrete wording:
Suggested change
| test('returns empty object when there is nested NaN value', () => { | |
| test('treats NaN -> NaN as unchanged', () => { |
| @@ -3,6 +3,10 @@ import { isDate, isEmpty, isObject, properObject } from '../utils'; | |||
| const diff = (lhs, rhs) => { | |||
| if (lhs === rhs) return {}; // equal return no diff | |||
|
|
|||
| if (typeof lhs === "number" && typeof rhs === "number") { | |||
| if (isNaN(lhs) && isNaN(rhs)) return {}; // NaN is equal | |||
| } | |||
anko
Jan 7, 2020
Could use Number.isNaN to check both Number type and NaN value simultaneously.
- if (typeof lhs === "number" && typeof rhs === "number") {
- if (isNaN(lhs) && isNaN(rhs)) return {}; // NaN is equal
- }
+ if (Number.isNan(lhs) && Number.isNan(rhs)) return {}; // NaN is equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NaN cannot be checked as equality. This commit add a test based on isNaN