Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
chore: Upgrade react, react-dom, react-native to latests versions #698
Conversation
Upgrading react-native-linear-gradient is mandatory as it fixes a compatibility problem: react-native-linear-gradient/react-native-linear-gradient#235
|
Genuinely excited to see how much it approves perf :) Can test on my iPhone when I'm home tonight if @chinesedfan doesn't get to it in time. |
|
Please do \o/ |
|
@machour Great improvement. I just see the logo in a flash then events list is there! Except a tiny indentation question and |
ios/GitPoint/AppDelegate.m
Outdated
| #else | ||
| jsCodeLocation = [CodePush bundleURL]; | ||
| jsCodeLocation = [CodePush bundleURL]; |
|
@chinesedfan Fixed the whitespaces changes |
ios/GitPoint/AppDelegate.m
Outdated
| @@ -20,9 +20,9 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:( | |||
| { | |||
| NSURL *jsCodeLocation; | |||
|
|
|||
|
|
|||
chinesedfan
Jan 27, 2018
Member
the pure empty line
@machour Sorry, I didn't comment very clearly before.
machour
Jan 27, 2018
Author
Member
Originally there was a line with a single space in it. I just removed it all together.
Not sure if I'm following you though :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
Resurrecting #523, I updated react, react-native to their latests versions using🎉
react-native-git-upgrade. I then proceeded to fix conflicts and get rid ofindex.ios.js&index.android.jsin favor ofindex.jsTested the application on both iOS and Android simulator, nothing seems to brake.
The app startup is quicker, it becomes responsive as soon as it's launched, overall, it seems to be on steroïds ... WOW.
I was only able to validate this on Android, as I never was able to run the app on iOS without hardcoding my IP in
AppDelegate.m. @chinesedfan could you give it a try on iOS ?For this PR, the best thing is to
rm -rf node_modulesand thenyarn && yarn run link && yarn start --reset-cachePS: Upgrading react-native-linear-gradient is mandatory as it fixes a compatibility problem: react-native-linear-gradient/react-native-linear-gradient#235