X Tutup
The Wayback Machine - https://web.archive.org/web/20201223144245/https://github.com/freeCodeCamp/devdocs/pull/1286
Skip to content

/ devdocs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Go version to 1.15 #1286

Merged
merged 1 commit into from Nov 12, 2020
Merged

Update the Go version to 1.15 #1286

merged 1 commit into from Nov 12, 2020

Conversation

@ocavue
Copy link
Contributor

@ocavue ocavue commented Oct 22, 2020

If you're updating an existing documentation to it's latest version, please ensure that you have:

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good
@ocavue
Update the Go version
Loading status checks…
8d5cebd
@ocavue
Copy link
Contributor Author

@ocavue ocavue commented Oct 22, 2020

There are two things I'd like to confirm:

  1. The document and Gemfile require Roby v2.6. But since I didn't have Ruby on my computer, I used Github Codespace to develop this PR, which has only Rudy v2.7 installed. bundle exec rackup --host 0.0.0.0 works fine so I think I can ignore the version conflict?
    image
  2. After edit scrapers/go.rb and running thor docs:generate, the document of Go v1.15 has been generated successfully. However, the generated files (public/docs/go) are ignored by Git and the document didn't say anything about adding generated documents. Thus, I guess I don't need to include those generated file into the Git repository?
@simon04 simon04 merged commit d1730c8 into freeCodeCamp:master Nov 12, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@simon04
Copy link
Contributor

@simon04 simon04 commented Nov 12, 2020

Thanks! The docs are now live on https://devdocs.io/go/
@simon04 simon04 self-assigned this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simon04 simon04

Labels
docs/update
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ocavue @simon04
You can’t perform that action at this time.
X Tutup