X Tutup
The Wayback Machine - https://web.archive.org/web/20201223144339/https://github.com/freeCodeCamp/devdocs/pull/1234
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby documentation (2.7.1) #1234

Merged
merged 2 commits into from Nov 13, 2020
Merged

Conversation

@davidcgl
Copy link
Contributor

@davidcgl davidcgl commented May 23, 2020

Adding documentation for Ruby 2.7.

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date and that the documentation's entry in the array in about_tmpl.coffee matches it's data in self.attribution
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

Additional steps:

  • Downloaded Ruby 2.7.1: https://cache.ruby-lang.org/pub/ruby/2.7/ruby-2.7.1.tar.bz2
  • Compiled Ruby: ./configure --with-openssl-dir="/usr/local/opt/openssl" && make html
  • Copied ruby-2.7.1/.ext/html to devdocs/docs/ruby~2.7
  • thor docs:generate ruby --force
  • Started the local server: bundle exec rackup
  • Checked that Ruby 2.7 docs are rendered (see screenshot)

Screen Shot 2020-05-23 at 12 38 28 PM

@kristallizer
Copy link

@kristallizer kristallizer commented Jul 22, 2020

Hey @davidcgl, do you know what's the status of this pull request?

@jmgarnier
Copy link

@jmgarnier jmgarnier commented Sep 24, 2020

Would be nice to have this PR merged ;)

@davidcgl
Copy link
Contributor Author

@davidcgl davidcgl commented Sep 24, 2020

Based on recent conversation on Gitter [0], there are currently no active maintainers on this project. They are looking for new contributors to take over. Until then, I'm not sure if anyone will approve this PR.

[0] https://gitter.im/FreeCodeCamp/DevDocs

@davidcgl davidcgl requested a review from freeCodeCamp/devdocs as a code owner Nov 13, 2020
@simon04 simon04 merged commit f6f4614 into freeCodeCamp:master Nov 13, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.
X Tutup