Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor for context-awareness #1795
Open
Conversation
Until node understands how to cleanup a native node module asynchronously, we cannot allow nodegit to operate in a worker thread or it will die on exit. Other concerns... Process reuse in Electron may be a problem without async cleanup being a real thing.
We aren't allowed to call back to JavaScript in this case
Ensure baton data members are value initialized (since batons are trivial types)
We already lock in AcquireLocks
RHEL 7 is still fairly popular and on GCC 4.8.x
Windows fails to shutdown synchronously, so shutdown asynchronously. This is only supported by node 14.10+ currently. Should be backported to LTS releases shortly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ianhattendorf commentedSep 11, 2020
TLDR:
worker_threadsupport!app.allowRendererProcessReuse=trueFixes #1774