X Tutup
The Wayback Machine - https://web.archive.org/web/20201124093802/https://github.com/MagicStack/httptools/issues/52
Skip to content

/ httptools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change from 0.0.13->0.1.1 #52

Closed
alippai opened this issue Feb 9, 2020 · 2 comments
Closed

API change from 0.0.13->0.1.1 #52

alippai opened this issue Feb 9, 2020 · 2 comments

Comments

@alippai
Copy link

@alippai alippai commented Feb 9, 2020

The httptools 1.0.0 release notes say that there should be no breaking change, but upgrading httptools from version 0.0.13 breaks uvicorn tests:

PR: encode/uvicorn#569
Test: https://travis-ci.org/encode/uvicorn/jobs/647886597
@elprans
Copy link
Member

@elprans elprans commented Feb 9, 2020

You should NOT import anything from httptools.parser directly (that is private API). The only public API is whatever is available under httptools directly, including the exception classes.
elprans added a commit that referenced this issue Feb 9, 2020
@elprans
Fix httptools.__all__
Verified
This commit was signed with a verified signature.
elprans Elvis Pranskevichus
GPG key ID: 5036323AA98A9CEC Learn about signing commits
Loading status checks…
5e819f4 
While looking at #52, I noticed that `httptools.__all__` is incorrect
and doesn't actually include everything that is exported by the module,
which might entice the users to import from the private submodule
directly.

Fixes: #52
@elprans elprans mentioned this issue Feb 9, 2020
Merged
@elprans
Copy link
Member

@elprans elprans commented Feb 9, 2020

#53 restores the behavior of 0.0.13, but please fix your code to not import anything from httptools submodules, we will make them private in a future release.
@alippai alippai mentioned this issue Feb 9, 2020
Closed
elprans added a commit that referenced this issue Feb 11, 2020
@elprans
Fix httptools.__all__
Verified
This commit was signed with a verified signature.
elprans Elvis Pranskevichus
GPG key ID: 5036323AA98A9CEC Learn about signing commits
Loading status checks…
db497f9 
While looking at #52, I noticed that `httptools.__all__` is incorrect
and doesn't actually include everything that is exported by the module,
which might entice the users to import from the private submodule
directly.

Fixes: #52
@elprans elprans closed this in #53 Feb 29, 2020
elprans added a commit that referenced this issue Feb 29, 2020
@elprans
Fix httptools.__all__
Loading status checks…
9340d32 
While looking at #52, I noticed that `httptools.__all__` is incorrect
and doesn't actually include everything that is exported by the module,
which might entice the users to import from the private submodule
directly.

Fixes: #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix httptools.__all__
2 participants
@alippai @elprans
You can’t perform that action at this time.
X Tutup