X Tutup
The Wayback Machine - https://web.archive.org/web/20201111045712/https://github.com/flutter/flutter/pull/45373
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License update #45373

Merged
merged 8 commits into from Nov 27, 2019
Merged

License update #45373

merged 8 commits into from Nov 27, 2019

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Nov 22, 2019

  • Update project.pbxproj files to say Flutter rather than Chromium.
  • The templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
  • Update copyrights on all files to be consistent.
  • Remove copyrights from templates.
  • Update the copyright notice checker to require a standard notice on all files.

For review purposes you are encouraged to use the separate commits.

Copy link
Member

@goderbauer goderbauer left a comment

RSLGTM

(I did not look at every single changed license header)

@Hixie Hixie force-pushed the Hixie:licenses branch 2 times, most recently from c716589 to 1eb6b08 Nov 22, 2019
@Hixie Hixie marked this pull request as ready for review Nov 22, 2019
@Hixie Hixie requested a review from jmagman as a code owner Nov 22, 2019
@jmagman
Copy link
Member

@jmagman jmagman commented Nov 22, 2019

A few more if you look for "Google LLC" like

@Hixie
Copy link
Contributor Author

@Hixie Hixie commented Nov 22, 2019

@jmagman interesting.

@Hixie Hixie force-pushed the Hixie:licenses branch from 1eb6b08 to fec490a Nov 27, 2019
@goderbauer
Copy link
Member

@goderbauer goderbauer commented Nov 27, 2019

The tree is green, but the tests on this PR are not. :)

@Hixie Hixie force-pushed the Hixie:licenses branch from fec490a to 17d4d48 Nov 27, 2019
Hixie added 6 commits Nov 21, 2019
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
…ions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
Also, make sure templates don't have copyrights.
Hixie added 2 commits Nov 27, 2019
Remove copyrights from templates as otherwise it will cause these files not to match the files created during `flutter create` which will then cause our automigration code to fail.
@Hixie Hixie force-pushed the Hixie:licenses branch from 17d4d48 to 97071e2 Nov 27, 2019
@Hixie Hixie merged commit 449f4a6 into flutter:master Nov 27, 2019
53 checks passed
53 checks passed
add_to_app_tests-macos Task Summary
Details
WIP Ready for review
Details
analyze-linux Task Summary
Details
build_tests-linux Task Summary
Details
build_tests-macos Task Summary
Details
build_tests-windows Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
customer_testing-macos Task Summary
Details
customer_testing-windows Task Summary
Details
deploy_gallery-linux Task Summary
Details
deploy_gallery-macos Task Summary
Details
docs-linux Task Summary
Details
firebase_test_lab_tests-linux Task Summary
Details
flutter-build
Details
framework_tests-libraries-linux Task Summary
Details
framework_tests-libraries-macos Task Summary
Details
framework_tests-libraries-windows Task Summary
Details
framework_tests-misc-linux Task Summary
Details
framework_tests-misc-macos Task Summary
Details
framework_tests-misc-windows Task Summary
Details
framework_tests-widgets-linux Task Summary
Details
framework_tests-widgets-macos Task Summary
Details
framework_tests-widgets-windows Task Summary
Details
hostonly_devicelab_tests-0-linux Task Summary
Details
hostonly_devicelab_tests-0-macos Task Summary
Details
hostonly_devicelab_tests-0-windows Task Summary
Details
hostonly_devicelab_tests-1-linux Task Summary
Details
hostonly_devicelab_tests-1-macos Task Summary
Details
hostonly_devicelab_tests-1-windows Task Summary
Details
hostonly_devicelab_tests-2-linux Task Summary
Details
hostonly_devicelab_tests-2-macos Task Summary
Details
hostonly_devicelab_tests-2-windows Task Summary
Details
hostonly_devicelab_tests-3_last-linux Task Summary
Details
hostonly_devicelab_tests-3_last-macos Task Summary
Details
hostonly_devicelab_tests-3_last-windows Task Summary
Details
tool_tests-commands-linux Task Summary
Details
tool_tests-commands-macos Task Summary
Details
tool_tests-commands-windows Task Summary
Details
tool_tests-general-linux Task Summary
Details
tool_tests-general-macos Task Summary
Details
tool_tests-general-windows Task Summary
Details
tool_tests-integration-linux Task Summary
Details
tool_tests-integration-macos Task Summary
Details
tool_tests-integration-windows Task Summary
Details
web_tests-0-linux Task Summary
Details
web_tests-1-linux Task Summary
Details
web_tests-2-linux Task Summary
Details
web_tests-3-linux Task Summary
Details
web_tests-4-linux Task Summary
Details
web_tests-5-linux Task Summary
Details
web_tests-6-linux Task Summary
Details
web_tests-7_last-linux Task Summary
Details
@Hixie Hixie deleted the Hixie:licenses branch Nov 27, 2019
katallaxie added a commit to katallaxie/flutter that referenced this pull request Dec 3, 2019
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.
X Tutup