X Tutup
The Wayback Machine - https://web.archive.org/web/20201110005340/https://github.com/inlets/inlets/pull/194
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new latest Docker Tag #194

Draft
wants to merge 2 commits into
base: master
from
Draft

Add new latest Docker Tag #194

wants to merge 2 commits into from

Conversation

@marcosvrs
Copy link

@marcosvrs marcosvrs commented Sep 16, 2020

Description

  • Add new latest Docker Tag for multiple use cases:

    • Always get the latest version when creating the docker container.
    • Allow the users to use docker pull inlets/inlets without receiving the error: manifest for inlets/inlets:latest not found.
    • Allow the use of services like containrrr/watchtower to keep the containers always up to date.
  • Only update the latest tag if it's a git Tag.

How Has This Been Tested?

Manually ran the make manifest-latest command.
Environment: Ubuntu 18.04.4 LTS; Docker version 19.03.11, build dd360c7
The only error that I got was no permission to push.

How are existing users impacted? What migration steps/scripts do we need?

None.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
@derek
Copy link

@derek derek bot commented Sep 16, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@marcosvrs marcosvrs force-pushed the marcosvrs:patch-1 branch 2 times, most recently from 345dcad to f9e228b Sep 16, 2020
@alexellis
Copy link
Member

@alexellis alexellis commented Sep 17, 2020

Hi @marcosvrs thanks for your interest in inlets.

Please can I ask you to read the contribution guide before continuing with this PR? They are very brief so it won't take you long.

The primary thing missing here is the issue to propose the changes you want and why you feel that they are required, along with the OK to go ahead.

https://github.com/inlets/inlets/blob/master/CONTRIBUTING.md

Regards,

Alex

@marcosvrs
Copy link
Author

@marcosvrs marcosvrs commented Sep 18, 2020

Hi @marcosvrs thanks for your interest in inlets.

Please can I ask you to read the contribution guide before continuing with this PR? They are very brief so it won't take you long.

The primary thing missing here is the issue to propose the changes you want and why you feel that they are required, along with the OK to go ahead.

https://github.com/inlets/inlets/blob/master/CONTRIBUTING.md

Regards,

Alex

I haven't really see the necessity of creating an issue, but I did it as required.

Run manifest-latest job after_success

Signed-off-by: Marcos V. Rubido <github@marcosvrs.com>
@marcosvrs marcosvrs force-pushed the marcosvrs:patch-1 branch from f9e228b to 6c63d6f Sep 18, 2020
@derek derek bot removed the no-dco label Sep 18, 2020
…n git Tag

Signed-off-by: Marcos V. Rubido <github@marcosvrs.com>
@marcosvrs marcosvrs force-pushed the marcosvrs:patch-1 branch from 6c63d6f to 08648dc Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup