X Tutup
The Wayback Machine - https://web.archive.org/web/20210129185245/https://github.com/google/go-github/issues/1639
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create workflow dispatch event by filename #1639

Closed
n1lesh opened this issue Oct 11, 2020 · 2 comments
Closed

Can't create workflow dispatch event by filename #1639

n1lesh opened this issue Oct 11, 2020 · 2 comments
Assignees

Comments

@n1lesh
Copy link
Contributor

@n1lesh n1lesh commented Oct 11, 2020

Noticed that, GitHub API docs: Create a workflow dispatch event, let's you create dispatch event by both workflowID and Filename.

However, PR #1623 adds support for just workflowID, with CreateWorkflowDispatchEvent.

Can we split it into two funcs for each type, as that's the general implementation in other APIs?

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Oct 11, 2020

Excellent catch, @n1lesh - thank you! Yes, that would be consistent and generally useful.
Let's do that, please.

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Oct 11, 2020

This will be a breaking API change, but I think we should do it, so I've labeled it as such.

@gmlewis gmlewis closed this in #1640 Dec 2, 2020
gmlewis pushed a commit that referenced this issue Dec 2, 2020
Fixes #1639.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
X Tutup