X Tutup
The Wayback Machine - https://web.archive.org/web/20210129184808/https://github.com/google/go-github/issues/1567
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListMatchingRefs does not work with the pagination options #1567

Open
nbramblett opened this issue Jun 22, 2020 · 1 comment
Open

ListMatchingRefs does not work with the pagination options #1567

nbramblett opened this issue Jun 22, 2020 · 1 comment

Comments

@nbramblett
Copy link

@nbramblett nbramblett commented Jun 22, 2020

I noticed this today while querying a repo with 101 refs. When ListMatchingRefs was called with no ReferenceListOptions provided, it provided a complete list of 101 refs, without any pagination needed.

It also repeated this behavior when provided a ReferenceListOptions that had defined PerPage: X, Page: 1. The expected behavior in this case would be that only the first X refs would be returned.

Given that the matching-refs endpoint no longer seems to respect pagination, I believe the best course of action would be to either update the ReferenceListOptions struct to reflect this change, or to simply remove the object from the ListMatchingRefs method.

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jun 23, 2020

Before we take any action on this endpoint, could you please contact support@github.com and ask what their recommendation is, then report back here?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
X Tutup