X Tutup
The Wayback Machine - https://web.archive.org/web/20201108162442/https://github.com/PowerShell/PowerShell-Native/pull/57
Skip to content

/ PowerShell-Native

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the agent pool for signing phase #57

Merged
merged 2 commits into from Oct 15, 2020
Merged

Change the agent pool for signing phase #57

merged 2 commits into from Oct 15, 2020

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Oct 15, 2020

PowerShell pool is deprecated. Using the latest pool.
@adityapatwardhan
Change the agent pool for signing phase
Loading status checks…
6f5ce18
@adityapatwardhan adityapatwardhan requested a review from TravisEz13 Oct 15, 2020
@TravisEz13
TravisEz13 reviewed Oct 15, 2020
View changes
tools/releaseBuild/yaml/releaseBuild.yml Outdated
@@ -30,10 +30,9 @@ stages:

- job: SignWin
pool:
name: PowerShell
name: Package ES Standard Build
demands:
- DotNetFramework

This comment has been minimized.

Sign in to view
@TravisEz13

TravisEz13 Oct 15, 2020 •
edited
Member

You can remove this too, it's dynamically added on windows if you use the PowerShell taks
@TravisEz13
TravisEz13 approved these changes Oct 15, 2020
View changes
@TravisEz13
TravisEz13 reviewed Oct 15, 2020
View changes
tools/releaseBuild/yaml/releaseBuild.yml Outdated
demands:
- DotNetFramework
Comment on lines 34 to 35

This comment has been minimized.

Sign in to view
@TravisEz13

TravisEz13 Oct 15, 2020
Member

Suggested change
demands:
- DotNetFramework
@TravisEz13
TravisEz13 reviewed Oct 15, 2020
View changes
tools/releaseBuild/yaml/releaseBuild.yml Outdated
demands:
- DotNetFramework
Comment on lines 82 to 83

This comment has been minimized.

Sign in to view
@TravisEz13

TravisEz13 Oct 15, 2020
Member

Suggested change
demands:
- DotNetFramework
@adityapatwardhan
Address CR comments
Loading status checks…
d45f377
@TravisEz13
TravisEz13 approved these changes Oct 15, 2020
View changes
@adityapatwardhan adityapatwardhan merged commit 14dfaf1 into PowerShell:master Oct 15, 2020
6 checks passed
6 checks passed
PowerShell-Native-CI-Linux #PR-57-20201015.02 succeeded
Details
PowerShell-Native-CI-Static-Analysis #PR-57-20201015.02 succeeded
Details
PowerShell-Native-CI-Windows #PR-57-20201015.02 succeeded
Details
PowerShell-Native-CI-macOS #PR-57-20201015.02 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
@adityapatwardhan adityapatwardhan deleted the adityapatwardhan:FixSigningPool branch Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@adityapatwardhan @TravisEz13
You can’t perform that action at this time.
X Tutup