X Tutup
The Wayback Machine - https://web.archive.org/web/20220423200522/https://github.com/nodejs/node/pull/35817
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: make the benchmark tool work with Node 10 #35817

Closed
wants to merge 1 commit into from
Closed

benchmark: make the benchmark tool work with Node 10 #35817

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Oct 26, 2020

Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@joyeecheung
benchmark: make the benchmark tool work with Node 10
49f7a48 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.
@nodejs-github-bot nodejs-github-bot added the benchmark label Oct 26, 2020
lpinca
lpinca reviewed Oct 27, 2020
View changes
benchmark/common.js Show resolved Hide resolved
@Trott Trott added the request-ci label Oct 30, 2020
@github-actions github-actions bot removed the request-ci label Oct 30, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Oct 30, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33969/

mhdawson
mhdawson approved these changes Oct 30, 2020
View changes
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

@lpinca lpinca added the request-ci label Oct 31, 2020
@github-actions github-actions bot removed the request-ci label Oct 31, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Oct 31, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33987/

@mhdawson mhdawson added the request-ci label Nov 2, 2020
@github-actions github-actions bot removed the request-ci label Nov 2, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34025/

mmarchini
mmarchini approved these changes Nov 3, 2020
View changes
Copy link
Contributor

@mmarchini mmarchini left a comment

any way we can test/lint for valid syntax for Node.js v10?

@richardlau
Copy link
Member

@richardlau richardlau commented Nov 3, 2020

any way we can test/lint for valid syntax for Node.js v10?

Run the lint action with Node.js 10?

joyeecheung added a commit that referenced this issue Nov 4, 2020
@joyeecheung
benchmark: make the benchmark tool work with Node 10
dbcadf0 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@joyeecheung
Copy link
Member Author

@joyeecheung joyeecheung commented Nov 4, 2020

Landed in dbcadf0, thanks!

@joyeecheung joyeecheung closed this Nov 4, 2020
targos pushed a commit that referenced this issue Nov 4, 2020
@joyeecheung @targos
benchmark: make the benchmark tool work with Node 10
76ebae4 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@targos targos mentioned this pull request Nov 4, 2020
Merged
BethGriggs pushed a commit that referenced this issue Dec 8, 2020
@joyeecheung @BethGriggs
benchmark: make the benchmark tool work with Node 10
5db0b07 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
BethGriggs pushed a commit that referenced this issue Dec 10, 2020
@joyeecheung @BethGriggs
benchmark: make the benchmark tool work with Node 10
c062d0b 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this issue Dec 15, 2020
@joyeecheung @BethGriggs
benchmark: make the benchmark tool work with Node 10
f648796 
Avoid using class fields in the benchmark tools since they are
not available in Node 10. This can be reverted when Node 10
reaches EOL.

PR-URL: #35817
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@Trott Trott

@watilde watilde

@gengjiawen gengjiawen

@mmarchini mmarchini

@mhdawson mhdawson

@ZYSzys ZYSzys

Assignees
No one assigned
Labels
benchmark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@joyeecheung @nodejs-github-bot @richardlau @Trott @lpinca @watilde @gengjiawen @mmarchini @mhdawson @ZYSzys
X Tutup