stream: fix legacy pipe error handling #35257
Closed
Conversation
ronag
force-pushed
the
legacy-error-handling
branch
2 times, most recently
from
0aace1a
to
c07e7a5
mcollina
requested changes
Sep 18, 2020
|
Needs a rebase. Looks good to me, but I'm usually hesitant to |
mcollina
approved these changes
Sep 22, 2020
lgtm
lpinca
approved these changes
Sep 22, 2020
Commit Queue failed- Loading data for nodejs/node/pull/35257 ✔ Done loading data for nodejs/node/pull/35257 ----------------------------------- PR info ------------------------------------ Title stream: fix legacy pipe error handling (#35257) Author Robert Nagy (@ronag) Branch ronag:legacy-error-handling -> nodejs:master Labels lts-watch-v12.x, stream Commits 2 - stream: fix legacy pipe error handling - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/35257 Fixes: https://github.com/nodejs/node/issues/35237 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35257 Fixes: https://github.com/nodejs/node/issues/35237 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup ✖ GitHub CI is still running ℹ Last Full PR CI on 2020-09-22T20:58:51Z: https://ci.nodejs.org/job/node-test-pull-request/33202/ - Querying data for job/node-test-pull-request/33202/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Fri, 18 Sep 2020 13:39:55 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/35257#pullrequestreview-493519435 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35257#pullrequestreview-493754259 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
|
@mcollina do you know if the commit queue auto squashes? |
Trott
approved these changes
Sep 23, 2020
Trott
added a commit
to Trott/io.js
that referenced
this issue
Sep 23, 2020
Fixes: nodejs#35237 PR-URL: nodejs#35257 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 6be80e1 |
|
@ronag no it doesn't, it will only autosquash if used with I've implemented nodejs/node-core-utils#490 but it is not yet integrated into this repo. |
|
This doesn't land cleanly on v14.x @ronag would you be able to backport? |
joesepi
added a commit
to joesepi/node
that referenced
this issue
Jan 8, 2021
Fixes: nodejs#35237 PR-URL: nodejs#35257 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes: #35237
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe text was updated successfully, but these errors were encountered: