util: improve getStringWidth performance #33674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot
added
the
util
BridgeAR
added
the
performance
addaleax
approved these changes
May 31, 2020
jasnell
approved these changes
Jun 1, 2020
tniessen
approved these changes
Jun 18, 2020
antsmartian
approved these changes
Jul 8, 2020
20 tasks
17 tasks
16 tasks
12 tasks
9 tasks
10 tasks
targos
added
the
author ready
addaleax
added a commit
that referenced
this issue
Jul 20, 2020
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33674 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
|
Landed in 2e82982 |
cjihrig
added a commit
that referenced
this issue
Jul 23, 2020
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33674 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
MylesBorins
added a commit
that referenced
this issue
Jul 27, 2020
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33674 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
addaleax
added a commit
that referenced
this issue
Sep 22, 2020
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33674 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax
added a commit
that referenced
this issue
Sep 22, 2020
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33674 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This makes sure the common path does not normalize the input string.
It's only required for characters that are outside of the ASCII range.
Signed-off-by: Ruben Bridgewater ruben@bridgewater.de
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes