X Tutup
The Wayback Machine - https://web.archive.org/web/20201108032035/https://github.com/flutter/flutter/pull/54206
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating codeowners for goldens #54206

Merged
merged 1 commit into from Apr 7, 2020
Merged

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 7, 2020

Description

This removes an obsolete pattern for an old golden file, and replaces it with new code ownership for goldens.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
@Piinks Piinks requested a review from jmagman as a code owner Apr 7, 2020
@googlebot googlebot added the cla: yes label Apr 7, 2020
@jmagman
jmagman approved these changes Apr 7, 2020
Copy link
Member

@jmagman jmagman left a comment

LGTM!

@fluttergithubbot fluttergithubbot merged commit 2ce36f6 into flutter:master Apr 7, 2020
15 checks passed
15 checks passed
WIP Ready for review
Details
analyze-linux Task Summary
Details
build_tests-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
customer_testing-macos Task Summary
Details
customer_testing-windows Task Summary
Details
deploy_gallery-linux Task Summary
Details
deploy_gallery-macos Task Summary
Details
firebase_test_lab_tests-linux Task Summary
Details
flutter-build
Details
hostonly_devicelab_tests-0-linux Task Summary
Details
hostonly_devicelab_tests-1-linux Task Summary
Details
hostonly_devicelab_tests-2-linux Task Summary
Details
hostonly_devicelab_tests-3_last-linux Task Summary
Details
zanderso added a commit to zanderso/flutter that referenced this pull request Apr 10, 2020
annorax added a commit to annorax/flutter that referenced this pull request Apr 30, 2020
onatcipli added a commit to onatcipli/flutter that referenced this pull request May 15, 2020
onatcipli added a commit to onatcipli/flutter that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.
X Tutup